Fix all DAO tests by replacing deprecated queryForInt with queryForObject#296
Merged
Fix all DAO tests by replacing deprecated queryForInt with queryForObject#296
Conversation
Co-authored-by: rvosa <106490+rvosa@users.noreply.github.com>
Contributor
|
@copilot also fix the queryForInt() issue in the other DAO test files (UserDAOTest, MatrixDAOTest, RowSegmentDAOTest, AlgorithmDAOTest, AnalyzedDataDAOTest, StudyDAOTest, SubmissionDAOTest, PhyloTreeDAOTest) where it manifests |
Copilot
AI
changed the title
[WIP] Fix failing tests in PersonDAOTest
Fix PersonDAOTest by replacing deprecated queryForInt with queryForObject
Dec 21, 2025
Co-authored-by: rvosa <106490+rvosa@users.noreply.github.com>
Contributor
Author
Fixed in commit c72f229. Replaced |
Copilot
AI
changed the title
Fix PersonDAOTest by replacing deprecated queryForInt with queryForObject
Fix all DAO tests by replacing deprecated queryForInt with queryForObject
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DAO test failures caused by use of deprecated
jdbcTemplate.queryForInt(). Replaced withqueryForObject(sql, Integer.class)pattern for consistency across entire test suite.Changes
Replaced
queryForInt()calls withqueryForObject(sqlStr, Integer.class)in count verification assertions across 9 DAO test files:Total: 32 replacements
Impact
All DAO tests now use the modern Spring JDBC pattern consistently, ensuring maintainability and forward compatibility with newer Spring versions.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.