Skip to content

Revert breaking change #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxded merged 1 commit into from
Oct 17, 2024
Merged

Revert breaking change #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xbuild/src/cargo/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ impl CargoBuild {
}

pub fn set_sysroot(&mut self, path: &Path) {
let arg = format!("--sysroot=\"{}\"", path.display());
Copy link
Copy Markdown
Author

@maxded maxded Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure why adding quotations here breaks it for me on Windows. I printed out the provided path which returned the following:`

C:\Users\mdans\AppData\Local\x\Android.ndk

This seems correct to me 👀

let arg = format!("--sysroot={}", path.display());
self.add_cflag(&arg);
self.add_link_arg(&arg);
}
Expand Down