🌌 Use build.rustflags (and variants) as a replacement for environment variable to enable spaces in paths#3
Merged
Conversation
Jasper-Bekkers
approved these changes
Sep 26, 2024
Author
|
Should I link rust-lang/cargo#14398 ? |
Member
Only if it's merged to xbuild main? Might want to reopen the PR there too for the larger community. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rust-mobile#128
As per the docs https://doc.rust-lang.org/cargo/reference/config.html#buildrustflags
Using the
build.rutflagapproach allows for spaces in paths, as seen in https://github.com/rust-lang/docs.rs/blob/bcc1a2c9f63a62907abbe68dcbe3f73632a9a4de/crates/metadata/lib.rs#L256-L262Additionally, as suggested in rust-mobile#128 (comment),
setting
CC_SHELL_ESCAPED_FLAGS=1and inserting quotes around paths that are passed toC(XX)FLAGSsolves all the remaining issues (provided that cc-rs is updated to 1.1.11)