Take the 'connected' value into account in the case of a new NIC#1
Open
xenlo wants to merge 6 commits intoTomorrow9:fix_pr51066from
Open
Take the 'connected' value into account in the case of a new NIC#1xenlo wants to merge 6 commits intoTomorrow9:fix_pr51066from
xenlo wants to merge 6 commits intoTomorrow9:fix_pr51066from
Conversation
Tomorrow9
pushed a commit
that referenced
this pull request
Mar 12, 2019
…nsible#49191) (ansible#53445) * Fix for "AttributeError: 'module' object has no attribute 'cursors'" (ansible#49191) (#1) * Fix for "AttributeError: 'module' object has no attribute 'cursors'" (ansible#49191) * Adding changelog fragment for issue ansible#49191 and the following PR. * Update lib/ansible/module_utils/mysql.py Co-Authored-By: timorunge <timorunge@users.noreply.github.com>
Tomorrow9
pushed a commit
that referenced
this pull request
Apr 15, 2019
* Add win_hosts module added win_hosts module for easier manipulation of hosts entries in "%windir%\system32\drivers\etc\hosts" for windows systems * Update win_hosts.py * Add alias support to win_hosts module (#1) * win_hosts supports aliases added support for adding / removing aliases from a host entry, rather than adding a new entry added ability for win_hosts to detect aliases: `192.168.1.1 alias1 alias2 alias3` ``` win_hosts: host_name: alias2 ip_address: 192.168.1.1 ``` will result in `192.168.1.1 alias1 alias3` also includes `replace` and `add` as options for `ip_action` (`replace` is default) for example: ``` 192.168.1.1 my_reused_alias 192.168.1.2 my_reused_alias ``` with ``` win_hosts: host_name: my_reused_alias ip_address: 192.168.1.3 ip_action: add ``` the result will be ``` 192.168.1.1 my_reused_alias 192.168.1.2 my_reused_alias ``` but with `ip_action=replace` the result would be ``` 192.168.1.3 my_reused_alias ``` * fixed metadata version and version added * fix line endings * upload fixed line endings try to upload the file with the fixed line endings * aliases and canonical names are separate entities. added IPv4 and IPv6 validation * only makes changes if "check_mode" is false * improved behavior for duplicate aliases/entries. * adding tests * missing aliases file * fix trailing whitespace and uses explicit paths * Tweak tests to copy and restore original hosts file
Tomorrow9
force-pushed
the
fix_pr51066
branch
2 times, most recently
from
790c95c to
a281467
Compare
Tomorrow9
force-pushed
the
fix_pr51066
branch
5 times, most recently
from
1ac77d3 to
e3564ae
Compare
Tomorrow9
pushed a commit
that referenced
this pull request
Dec 2, 2019
ansible#65228) * adding encoding dump/import support for the mysql_db module, with updated documentation, and full test suite * fixing lint issue test ansible#3 * fixing lint issue test #1 * fixing lint issue test #1 second time * Improving Test to be re-entrant * improving test to not fail on centos/6 * Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml Comminting suggestion Co-Authored-By: Benjamin MALYNOVYTCH <bmalynovytch@users.noreply.github.com> * Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml comminting suggestion Co-Authored-By: Benjamin MALYNOVYTCH <bmalynovytch@users.noreply.github.com> * adding comment Adding comment to explain test strategy * Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml Co-Authored-By: Benjamin MALYNOVYTCH <bmalynovytch@users.noreply.github.com> * Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml Co-Authored-By: Benjamin MALYNOVYTCH <bmalynovytch@users.noreply.github.com> * Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml accepted Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru> * Update test/integration/targets/mysql_db/tasks/encoding_dump_import.yml Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru> * Update encoding_dump_import.yml * Fixing typoo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the review: ansible#52075 (comment)
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION