Skip to content

fix(test): fix mypy failure#3033

Merged
Green-Sky merged 1 commit intoTokTok:masterfrom
nickolay168:nickolay168/fix_mypy
Apr 29, 2026
Merged

fix(test): fix mypy failure#3033
Green-Sky merged 1 commit intoTokTok:masterfrom
nickolay168:nickolay168/fix_mypy

Conversation

@nickolay168
Copy link
Copy Markdown

@nickolay168 nickolay168 commented Apr 26, 2026

Fix the mypy failure in CI/CD.


This change is Reviewable

@github-actions github-actions Bot added the bug Bug fix for the user, not a fix to a build script label Apr 26, 2026
@nickolay168 nickolay168 marked this pull request as ready for review April 26, 2026 05:38
@nickolay168 nickolay168 requested a review from a team as a code owner April 26, 2026 05:38
Comment thread .github/workflows/ci.yml Outdated
@nickolay168 nickolay168 force-pushed the nickolay168/fix_mypy branch 4 times, most recently from 7dc9e7e to 2c500b2 Compare April 26, 2026 23:14
@nickolay168 nickolay168 requested a review from Green-Sky April 26, 2026 23:36
@Green-Sky
Copy link
Copy Markdown
Member

Green-Sky commented Apr 27, 2026

I saw robinlinden/libsodium-cmake@944cea4 , and I think that would be better.
Seems like they ship enough python in the runner.

Sorry for the back and forth (: .

@nickolay168 nickolay168 force-pushed the nickolay168/fix_mypy branch from 2c500b2 to 8016a50 Compare April 28, 2026 06:07
@nickolay168
Copy link
Copy Markdown
Author

I saw robinlinden/libsodium-cmake@944cea4 , and I think that would be better. Seems like they ship enough python in the runner.

Sorry for the back and forth (: .

Fixed. I have pinned the mypy version and but retained python version at 3.13.

Copy link
Copy Markdown
Member

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough.

@Green-Sky Green-Sky added this to the v0.2.23 milestone Apr 28, 2026
@nickolay168
Copy link
Copy Markdown
Author

Good enough.

Thank you! Should we merge a PR? I have tried to fix the Circle CI issue in my other PR by upgrading Bazel, but Circle CI takes the scriupt from master branch and I cannot check the fix.

@Green-Sky Green-Sky merged commit 8016a50 into TokTok:master Apr 29, 2026
77 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug fix for the user, not a fix to a build script

Development

Successfully merging this pull request may close these issues.

2 participants