Mission - Only run error checking in 3DEN - #778
Closed
Mike-MF wants to merge 1 commit into
Closed
Conversation
Member
|
It should still be logged somewhere. I am not a fan of this. 🤔 |
Member
Author
|
It is logged, during the check. There's just no point running these checks on a mission that's already been checked after the fact.
|
Member
|
But what if something wasn't caught in Eden? Previously, it would log the error and exit the function. Now it will not check and throw a script error somewhere else. |
Member
Author
|
You make a good point, perf cost on these checks is pretty minor given these functions don't run a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
baseSpectatorbecause knowing the spec screen is missing is kind of important.