Skip to content

Mission - Only run error checking in 3DEN - #778

Closed
Mike-MF wants to merge 1 commit into
masterfrom
mission-editorOnlyErrors
Closed

Mission - Only run error checking in 3DEN#778
Mike-MF wants to merge 1 commit into
masterfrom
mission-editorOnlyErrors

Conversation

@Mike-MF

@Mike-MF Mike-MF commented Jul 19, 2026

Copy link
Copy Markdown
Member

When merged this pull request will:

  • This should be the rest of them with the exception of baseSpectator because knowing the spec screen is missing is kind of important.

@Mike-MF Mike-MF added this to the 2.13.0 milestone Jul 19, 2026
@jonpas

jonpas commented Aug 4, 2026

Copy link
Copy Markdown
Member

It should still be logged somewhere. I am not a fan of this. 🤔
Why are we hiding this anyways, none of those errors should show in a reviewed mission?

@Mike-MF

Mike-MF commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

It is logged, during the check. There's just no point running these checks on a mission that's already been checked after the fact.

  • Review in 3den, errors pop and they get fixed.
  • Don't need them to pop on the server as they already happen via 3den test.

@jonpas

jonpas commented Aug 4, 2026

Copy link
Copy Markdown
Member

But what if something wasn't caught in Eden? Previously, it would log the error and exit the function. Now it will not check and throw a script error somewhere else.

@Mike-MF

Mike-MF commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

You make a good point, perf cost on these checks is pretty minor given these functions don't run a lot.

@Mike-MF Mike-MF closed this Aug 4, 2026
@Mike-MF Mike-MF removed this from the 2.13.0 milestone Aug 4, 2026
@jonpas
jonpas deleted the mission-editorOnlyErrors branch August 4, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants