Basic pinning support (PP-3116) - #203
Merged
Merged
Conversation
tdilauro
added this pull request to stack #204
September 28, 2026 01:01
1 task done
tdilauro
force-pushed
the
feature/pinning-basics
branch
from
September 28, 2026 17:59
ca7b404 to
9b9f3af
Compare
Coverage Report for CI Build 36521806022Coverage decreased (-2.8%) to 26.946%Details
Uncovered Changes
Coverage Regressions7 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
PoorBillyPilgrim
approved these changes
Sep 28, 2026
PoorBillyPilgrim
left a comment
Contributor
There was a problem hiding this comment.
This is great, @tdilauro. The accessibility feels robust. I tested locally and analyzed with Axe DevTools and WAVE; it all LGTM.
I just had a single comment, but non-blocking, so I'll go ahead and approve.
tdilauro
force-pushed
the
feature/pinning-basics
branch
from
September 29, 2026 04:28
9b9f3af to
52008ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds basic library pinning, behind a new feature flag.
PALACE_CPW_FEATURE_PINNINGenvironment variable totrueto enable pinning. It is off by default; while off, pin controls are hidden and stored pins are ignored. The flag is documented in the README with the other feature flags.useSignOutFlowhook. From the home page it clears the stored credentials only.AlertDialogcomponent for confirmation dialogs;LibraryCardgains a slot for the pin button.modallayer, so page content no longer shows through. This applies to all dialogs.Known limitations:
Important
This branch is stacked on PR #202. This PR must not be merged until that one lands.
Motivation and Context
Patrons should not have to find their library(ies) in the full list on every visit. Pinning keeps those libraries at the top of the library pickers on this device. The
PALACE_CPW_FEATURE_PINNINGflag allows us to test the feature without it surfacing to users before it is ready.[Jira PP-3116]
How Has This Been Tested?
Checklist:
Screenshots
Initially the full "Choose a library" and we click the pin icon

Confirm the pin

Now the library is pinned in "My Libraries"

Find another library

Confirm the pin and click "Do not show again"

The second library is pinned and we have the option to reset the confirmation dialog
