Visual and accessibility audit of i18n changes (PP-4711) - #198
Merged
Merged
Conversation
- LanguageSelector is hidden behind book cover on mobile view - provide localized title for Search input
tdilauro
approved these changes
Sep 10, 2026
tdilauro
left a comment
tdilauro
left a comment
Contributor
There was a problem hiding this comment.
This looks good! 🎉
Just a few questions / minor suggestions below.
Coverage Report for CI Build 34868574765Coverage remained the same at 30.142%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor changes to fix some visual and accessibility issues caused when translations were added:
Prevent
LanguageSelectorfrom being hidden behind book covers in mobile viewProvide localized title for
SearchcomponentSearchcomponent is being used in the header to conduct catalog-wide searches. The value returned onsearchData.shortNamecannot be guaranteed to be any particular value, but the majority of libraries provide "Search" as its value for which a translation can be provided. If any other value is provided that is not found in the translations, then the value fromsearchData.shortNamewill be used.Note
SearchData.shortNameshould never be null or undefined, but becausesearchDatahas been optionally chainingshortNamethen we'll maintain that check and provide an alternative value in case of any unlikely runtime errors.Motivation and Context
A final audit was needed to ensure translations met accessibility standards and that translations did not change or break visual layout of the UI:
LanguageSelectormenu was not usable on small screen sizes.titleattribute of inputs must be localized in order to meet accessibility standards.Jira PP-4711
How Has This Been Tested?
Checklist: