Fix project warnings

Author: inyutin-maxim

Roslyn.Testing/Analyzer/DiagnosticVerifier.cs

@@ -250,7 +250,6 @@ public static VerifyDiagnosticAnalyzerResult VerifyDiagnosticResults(this Diagno
 
 		if (expectedCount != actualCount)
 		{
-
 			var diagnosticsOutput = diagnostics.Any()
 				? FormatDiagnostics(analyzer, diagnostics)
 				: "    NONE.";
@@ -354,8 +353,7 @@ private static VerifyDiagnosticAnalyzerResult VerifyDiagnosticLocation(Diagnosti
 		var actualSpan = actual.GetLineSpan();
 
 		var isInExpectedFile = actualSpan.Path == expected.Path
-								|| (actualSpan.Path is not null
-									&& actualSpan.Path.Contains("Test0.")
+								|| (actualSpan.Path.Contains("Test0.")
 									&& expected.Path.Contains("Test."));
 
 		if (!isInExpectedFile)
@@ -454,53 +452,51 @@ private static string FormatDiagnostics(DiagnosticAnalyzer analyzer, Diagnostic[
 
 			foreach (var rule in rules)
 			{
-				if (rule is not null
-					&& rule.Id
-					== diagnostics[i]
-						.Id)
+				if (rule.Id != diagnostics[i].Id)
 				{
-					var location = diagnostics[i]
-						.Location;
+					continue;
+				}
 
-					if (location == Location.None)
-					{
-						builder.AppendFormat("GetGlobalResult({0}.{1})", analyzerType.Name, rule.Id);
-					} else
-					{
-						if (!location.IsInSource)
-						{
-							var msg =
-								$"Test base does not currently handle diagnostics in metadata locations. Diagnostic in metadata: {diagnostics[i]}{Environment.NewLine}";
+				var location = diagnostics[i]
+					.Location;
 
-							throw new(msg);
-						}
+				if (location == Location.None)
+				{
+					builder.AppendFormat("GetGlobalResult({0}.{1})", analyzerType.Name, rule.Id);
+				} else
+				{
+					if (!location.IsInSource)
+					{
+						var msg =
+							$"Test base does not currently handle diagnostics in metadata locations. Diagnostic in metadata: {diagnostics[i]}{Environment.NewLine}";
 
-						var resultMethodName = diagnostics[i]
-							.Location.SourceTree.FilePath.EndsWith(".cs")
-							? "GetCSharpResultAt"
-							: "GetBasicResultAt";
-
-						var linePosition = diagnostics[i]
-							.Location.GetLineSpan()
-							.StartLinePosition;
-
-						builder.AppendFormat("{0}({1}, {2}, {3}.{4})",
-							resultMethodName,
-							linePosition.Line + 1,
-							linePosition.Character + 1,
-							analyzerType.Name,
-							rule.Id);
+						throw new(msg);
 					}
 
-					if (i != diagnostics.Length - 1)
-					{
-						builder.Append(',');
-					}
+					var resultMethodName = location.SourceTree.FilePath.EndsWith(".cs")
+						? "GetCSharpResultAt"
+						: "GetBasicResultAt";
+
+					var linePosition = diagnostics[i]
+						.Location.GetLineSpan()
+						.StartLinePosition;
 
-					builder.AppendLine();
+					builder.AppendFormat("{0}({1}, {2}, {3}.{4})",
+						resultMethodName,
+						linePosition.Line + 1,
+						linePosition.Character + 1,
+						analyzerType.Name,
+						rule.Id);
+				}
 
-					break;
+				if (i != diagnostics.Length - 1)
+				{
+					builder.Append(',');
 				}
+
+				builder.AppendLine();
+
+				break;
 			}
 		}