Fix project warnings

Author: inyutin-maxim

Roslyn.Testing/Analyzer/DiagnosticVerifier.cs

@@ -241,16 +241,18 @@ private static Project CreateProject(string[] sources, string language, IEnumera
 	/// the code
 	/// </param>
 	public static VerifyDiagnosticAnalyzerResult VerifyDiagnosticResults(this DiagnosticAnalyzer analyzer,
-																		IEnumerable<Diagnostic> actualResults,
+																		IReadOnlyCollection<Diagnostic> actualResults,
 																		DiagnosticResult[] expectedResults)
 	{
 		var expectedCount = expectedResults.Length;
-		var actualCount = actualResults.Count();
+		var diagnostics = actualResults.ToArray();
+		var actualCount = diagnostics.Count();
 
 		if (expectedCount != actualCount)
 		{
-			var diagnosticsOutput = actualResults.Any()
-				? FormatDiagnostics(analyzer, actualResults.ToArray())
+
+			var diagnosticsOutput = diagnostics.Any()
+				? FormatDiagnostics(analyzer, diagnostics)
 				: "    NONE.";
 
 			var msg = GetMismatchNumberOfDiagnosticsMessage(expectedCount, actualCount, diagnosticsOutput);
@@ -263,7 +265,11 @@ public static VerifyDiagnosticAnalyzerResult VerifyDiagnosticResults(this Diagno
 			var actual = actualResults.ElementAt(i);
 			var expected = expectedResults[i];
 
-			if (expected.Line == -1 && expected.Column == -1)
+			if (expected is
+				{
+					Line: -1,
+					Column: -1
+				})
 			{
 				if (actual.Location != Location.None)
 				{

Roslyn.Testing/CodeFix/CSharpCodeFixProviderTest.cs

@@ -21,7 +21,7 @@ public abstract class CSharpCodeFixProviderTest<TDiagnosticAnalyzer, TCodeFixPro
 	/// <inheritdoc />
 	public override string PathToTestData => "./TestData/CodeFix/";
 
-	protected virtual IEnumerable<MetadataReference> GetAdditionalReferences() => [];
+	protected virtual IReadOnlyCollection<MetadataReference> GetAdditionalReferences() => [];
 
 	#endregion
 

Roslyn.Testing/CodeFix/CodeFixProviderTestExtensions.cs

@@ -77,7 +77,7 @@ public static VerifyCodeFixProviderResult VerifyFix(this CodeFixProvider codeFix
 														string newSource,
 														int? codeFixIndex,
 														bool allowNewCompilerDiagnostics,
-														IEnumerable<MetadataReference> additionalReferences = null)
+														IReadOnlyCollection<MetadataReference> additionalReferences = null)
 	{
 		var document = DiagnosticAnalyzerTestExtensions.CreateDocument(oldSource, language, additionalReferences);
 
@@ -155,7 +155,7 @@ private static string GetNewCompilerDiagnosticsIntroducedMessage(Document docume
 	/// on
 	/// </param>
 	/// <returns> The compiler diagnostics that were found in the code </returns>
-	private static IEnumerable<Diagnostic> GetCompilerDiagnostics(this Document document) => document.GetSemanticModelAsync()
+	private static IReadOnlyCollection<Diagnostic> GetCompilerDiagnostics(this Document document) => document.GetSemanticModelAsync()
 		.GetAwaiter()
 		.GetResult()
 		.GetDiagnostics();

System.IO.Abstractions.Analyzers.Tests/Analyzers/PathAnalyzerTests.cs

@@ -14,6 +14,7 @@ public class PathAnalyzerTests : CSharpDiagnosticAnalyzerTest<PathAnalyzer>
 	[InlineData("UsingStaticFalsePositive.txt")]
 	[InlineData("UsingStaticLinqFalsePositive.txt")]
 	[InlineData("NonRelatedFieldFalsePositive.txt")]
+	[InlineData("DtoFalsePositive.txt")]
 	public void Analyzer_is_not_triggered(string filename)
 	{
 		var source = ReadFile(filename);

System.IO.Abstractions.Analyzers.Tests/CodeFixes/DirectoryCodeFixTests.cs

@@ -19,7 +19,7 @@ public void CodeFix(string sourceBefore, string sourceAfter)
 		VerifyFix(sourceBeforeFix, sourceAfterFix, 0, true);
 	}
 
-	protected override IEnumerable<MetadataReference> GetAdditionalReferences() =>
+	protected override IReadOnlyCollection<MetadataReference> GetAdditionalReferences() =>
 	[
 		MetadataReference.CreateFromFile(typeof(IFileSystem).Assembly.Location)
 	];

System.IO.Abstractions.Analyzers.Tests/CodeFixes/DirectoryInfoCodeFixTests.cs

@@ -19,7 +19,7 @@ public void CodeFix(string sourceBefore, string sourceAfter)
 		VerifyFix(sourceBeforeFix, sourceAfterFix, 0, true);
 	}
 
-	protected override IEnumerable<MetadataReference> GetAdditionalReferences() =>
+	protected override IReadOnlyCollection<MetadataReference> GetAdditionalReferences() =>
 	[
 		MetadataReference.CreateFromFile(typeof(IFileSystem).Assembly.Location)
 	];

System.IO.Abstractions.Analyzers.Tests/CodeFixes/FileCodeFixTests.cs

@@ -19,7 +19,7 @@ public void CodeFix(string sourceBefore, string sourceAfter)
 		VerifyFix(sourceBeforeFix, sourceAfterFix, 0, true);
 	}
 
-	protected override IEnumerable<MetadataReference> GetAdditionalReferences() =>
+	protected override IReadOnlyCollection<MetadataReference> GetAdditionalReferences() =>
 	[
 		MetadataReference.CreateFromFile(typeof(IFileSystem).Assembly.Location)
 	];

System.IO.Abstractions.Analyzers.Tests/CodeFixes/FileInfoCodeFixTests.cs

@@ -19,7 +19,7 @@ public void CodeFix(string sourceBefore, string sourceAfter)
 		VerifyFix(sourceBeforeFix, sourceAfterFix, 0, true);
 	}
 
-	protected override IEnumerable<MetadataReference> GetAdditionalReferences() =>
+	protected override IReadOnlyCollection<MetadataReference> GetAdditionalReferences() =>
 	[
 		MetadataReference.CreateFromFile(typeof(IFileSystem).Assembly.Location)
 	];

System.IO.Abstractions.Analyzers.Tests/CodeFixes/FileServiceConstructorInitialCodeFixTests.cs

@@ -20,7 +20,7 @@ public void CodeFix(string sourceBefore, string sourceAfter)
 		VerifyFix(sourceBeforeFix, sourceAfterFix, 0, true);
 	}
 
-	protected override IEnumerable<MetadataReference> GetAdditionalReferences() =>
+	protected override IReadOnlyCollection<MetadataReference> GetAdditionalReferences() =>
 	[
 		MetadataReference.CreateFromFile(typeof(IFileSystem).Assembly.Location)
 	];

System.IO.Abstractions.Analyzers.Tests/CodeFixes/FileServiceInterfaceInjectionCodeFixTests.cs

@@ -24,7 +24,7 @@ public void CodeFix(string sourceBefore, string sourceAfter)
 		VerifyFix(sourceBeforeFix, sourceAfterFix, 0, true);
 	}
 
-	protected override IEnumerable<MetadataReference> GetAdditionalReferences() =>
+	protected override IReadOnlyCollection<MetadataReference> GetAdditionalReferences() =>
 	[
 		MetadataReference.CreateFromFile(typeof(IFileSystem).Assembly.Location)
 	];