TICKET 8321: add default role config option for test projects#170
TICKET 8321: add default role config option for test projects#170ukirst wants to merge 5 commits intoTestLinkOpenSourceTRMS:testlink_1_9from
Conversation
This reverts commit 6dee1ed.
|
function name => setUserRoleIDs($tproject_id, $role_id), has to be changed to setAllUsersToRole() |
|
function setUserRoleIDs($tproject_id, $role_id), need to be refactored to avoid multiple exit points |
|
$args->allRoles = $role_mgr->getAll($tprojectMgr->db, "WHERE id != 1 AND id != 2 the MAGIC NUMBERS 1 and 2 need to be replaced with the corresponding constants |
|
It seems that the default role on test project logic is only applied to PUBLIC projects, can you confirm this ? If answer is Yes then indication need to be provided to user who is configuring test project. |
|
@fmancardi Regarding your concern about deleting user roles and applying the default: |
|
Because the feature to set all users to a role for a test project exists, I will need to understand if this part of your implementation can be added. |
@fmancardi Please review changes for "default test project role" feature and merge, if ok.
Thank you.