Skip to content

Two small changes to get Test2 to fully work on EBCDIC systems. #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
exodist merged 2 commits into from
Jun 14, 2026
+4 −3
Merged

Two small changes to get Test2 to fully work on EBCDIC systems. #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf6455b
Get modules/Tools/Compare.t to pass on EBCDIC
khwilliamson Jun 8, 2025
df1b72d
Get Tools/Mock.pm to work on EBCDIC systems
khwilliamson May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/Test2/Tools/Mock.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,8 @@ sub _generate_class {
my $prefix = __PACKAGE__;

for (1 .. 100) {
my $postfix = join '', map { chr(rand(26) + 65) } 1 .. 32;
my $postfix = join '', map { chr(utf8::unicode_to_native(rand(26) + 65))

@exodist exodist Jun 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to insure the utf8 package is loaded first, is there a minimum perl version this works for?

@exodist exodist Jun 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing and it looks like we do not need to load utf8, and that this works back to 5.8. I will merge, then add some logic to skip the call on 5.6, but only cause it is not difficult, and there are still people using modern Test2 on 5.6 (yikes)

@khwilliamson khwilliamson Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it utf8: is always loaded, since 5.8. It's fine to not support EBCDIC before then. I haven't looked at what you may have done about 5.6, but I would just create a sub, say to_native that is defined to return its input for earlier than 5.8, and calls unicode_to_native for later. Hence no conditionals are added except for setup.

} 1 .. 32;
my $class = $prefix . '::__TEMP__::' . $postfix;
my $file = $class;
$file =~ s{::}{/}g;
Expand Down
4 changes: 2 additions & 2 deletions t/modules/Tools/Compare.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,12 +154,12 @@ subtest is => sub {

fail_table(
header => [qw/GOT OP CHECK/],
rows => [["\N{U+1}\N{U+2}\N{U+3}", 'eq', "\N{U+1}\N{U+2}\N{U+4}"]],
rows => [["\x{01}\x{02}\x{03}", 'eq', "\x{01}\x{02}\x{04}"]],
);

fail_table(
header => [qw/PATH GOT OP CHECK/],
rows => [['$*', "\N{U+1}\N{U+2}\N{U+3}", 'eq', "\N{U+1}\N{U+2}\N{U+4}"]],
rows => [['$*', "\x{01}\x{02}\x{03}", 'eq', "\x{01}\x{02}\x{04}"]],
);

event Ok => sub {
Expand Down
Loading