fix(ci): use literal environment name/url in release.yml - #122
Merged
Conversation
The env context cannot be evaluated in a job-level environment key, so tag pushes scheduled 0 jobs and the release workflow never ran.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the release workflow so tag pushes actually run: the
publish-to-pypijob'senvironment:key interpolated${{ env.ENVIRONMENT_NAME }}/${{ env.PYPI_PROJECT_URL }}, but GitHub Actions cannot evaluate theenvcontext in a job-levelenvironment:key. This caused every tag push (includingv1.9.0) to schedule 0 jobs and fail immediately, before any check run was even created.Replaces both with literal values (
name: pypi, the literal PyPI project URL) — no other changes.Once this merges,
v1.9.0's publish will be re-triggered (re-push the tag at the new merge commit) to actually gate CI and publish to PyPI.