Change small buttons to SpriteIconButton#1045
Conversation
|
would love to see this merged! Im trying to make a mod that moves the small buttons to the bottom and now ill have to do some extra workaround for modmenu |
Jab125
left a comment
Jab125
left a comment
There was a problem hiding this comment.
This would be a good time to make the mods icon shadow match the shadows of the icons next to it
| CONFIGURE_SPRITE_FOCUSED | ||
| ), 20, 20) | ||
| .build(); | ||
| this.configureButton.setPosition(width - 24, RIGHT_PANE_Y); |
There was a problem hiding this comment.
Is there no way to set the position in the builder?
There was a problem hiding this comment.
Its not possible to do in the builder.
|
@Jab125 I have reduced all textures filesizes with oxipng, which is why they appear as changed. |
|
For future reference, it's a lot nicer for maintainers to get maintenance stuff like reformatting code or compressing all the images in a separate PR from the feature change. That's probably what Jab125 is getting at there. |
|
Yeah that makes sense. Should i revert the image compression changes? |
|
I don't particularly mind in this case. No need to make more work for you. |
I agree, but TBH I have looked at it a few times and I can't see the difference, so it's going to have to be somebody else who "fixes" it... |
|
|
I think matching the shading of vanilla icons would be hard, since they are very inconsistent on that. |
|
Yes, I seem to recall seeing a Neoforge discussion about matching vanilla recently and they said the same thing -- "match which icon?" It doesn't help my eyesight isn't quite as good as it used to be. I'll merge whatever somebody says is better (unless even I can tell it's not). Until the next person comes with a new "better" version, then I'll merge that. |
|
I've made shadows that match the shadows of text 
|
5 participants
The goal of this PR is to improve visual compatibility with resource packs that replace vanilla button textures, but don't replace mod menu button textures.
It is done by splitting the button textures into sprites without the vanilla button texture background, and then using them on SpriteIconButton which renders them on top of whatever button texture minecraft is currently using.
Examples on some servers that use custom resource packs:
