fix(auth): keep session when server is unreachable on startup - #37
Open
Beta-Blaze wants to merge 1 commit into
Open
fix(auth): keep session when server is unreachable on startup#37Beta-Blaze wants to merge 1 commit into
Beta-Blaze wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
App logged the user out on restart whenever the token check failed for any reason, including a network blip.
Changes Made
AppContext.tsx: startup auth probe now only clears the JWT on a 401. Any other failure (offline, 502, timeout) keeps the session and the app retries on the next request. The existing 401 interceptor still signs out if the token really is bad.data_unlockedcheck from the startup and foreground auth checks. It gates encrypted data, not login state, so a locked vault was treated as "not logged in".Related Issues
Screenshots / Demos
Tested on a release build: sign in, force close, reopen, still signed in. Used to log out every time.
Checklist