Skip to content

addressed PR review comments of trino team #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sc250072 merged 3 commits into from
Sep 28, 2025
Merged

addressed PR review comments of trino team #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84d34aa
addressed PR review comments of trino team
sc250072 Sep 28, 2025
29fe785
Refactor Teradata documentation for clarity and formatting improvements
sc250072 Sep 28, 2025
0eba390
Fix package declaration in Region.java for consistency
sc250072 Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
321 changes: 85 additions & 236 deletions docs/src/main/sphinx/connector/teradata.md
View file
Open in desktop

Large diffs are not rendered by default.

96 changes: 73 additions & 23 deletions plugin/trino-teradata/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>io.trino</groupId>
<artifactId>trino-root</artifactId>
<version>476</version>
<version>478-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

Expand All @@ -13,33 +13,41 @@
<name>${project.artifactId}</name>
<description>Trino - Teradata connector</description>

<properties>
<air.compiler.fail-warnings>true</air.compiler.fail-warnings>
</properties>

<dependencies>

<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>

<dependency>
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
<classifier>classes</classifier>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>configuration</artifactId>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-base-jdbc</artifactId>
<groupId>io.airlift</groupId>
<artifactId>log</artifactId>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-plugin-toolkit</artifactId>
<artifactId>trino-base-jdbc</artifactId>
</dependency>

<dependency>
<groupId>org.jdbi</groupId>
<artifactId>jdbi3-core</artifactId>
<groupId>io.trino</groupId>
<artifactId>trino-plugin-toolkit</artifactId>
</dependency>

<dependency>
Expand Down Expand Up @@ -84,12 +92,6 @@
<scope>provided</scope>
</dependency>

<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_annotations</artifactId>
Expand All @@ -105,7 +107,13 @@

<dependency>
<groupId>io.airlift</groupId>
<artifactId>log</artifactId>
<artifactId>concurrent</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>json</artifactId>
<scope>runtime</scope>
</dependency>

Expand All @@ -117,7 +125,13 @@

<dependency>
<groupId>io.airlift</groupId>
<artifactId>http-server</artifactId>
<artifactId>units</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>configuration-testing</artifactId>
<scope>test</scope>
</dependency>

Expand All @@ -132,13 +146,39 @@
<artifactId>testing</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>tracing</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-base-jdbc</artifactId>
<type>test-jar</type>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-exchange-filesystem</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-exchange-filesystem</artifactId>
<type>test-jar</type>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-jmx</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-main</artifactId>
Expand All @@ -154,37 +194,44 @@

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-testing</artifactId>
<artifactId>trino-parser</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-testing-services</artifactId>
<artifactId>trino-plugin-toolkit</artifactId>
<type>test-jar</type>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-tpch</artifactId>
<artifactId>trino-testing</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.trino.tpch</groupId>
<artifactId>tpch</artifactId>
<groupId>io.trino</groupId>
<artifactId>trino-testing-containers</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>jakarta.servlet</groupId>
<artifactId>jakarta.servlet-api</artifactId>
<groupId>io.trino</groupId>
<artifactId>trino-testing-services</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<groupId>io.trino</groupId>
<artifactId>trino-tpch</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.trino.tpch</groupId>
<artifactId>tpch</artifactId>
<scope>test</scope>
</dependency>

Expand Down Expand Up @@ -223,6 +270,9 @@
<configuration>
<ignoredDependencies>
<ignoredDependency>com.fasterxml.jackson.core:jackson-core</ignoredDependency>
<ignoredDependency>com.fasterxml.jackson.core:jackson-databind</ignoredDependency>
<ignoredDependency>com.google.guava:guava</ignoredDependency>
<ignoredDependency>io.airlift:log</ignoredDependency>
</ignoredDependencies>
</configuration>
</plugin>
Expand Down
46 changes: 0 additions & 46 deletions plugin/trino-teradata/src/main/java/io/trino/plugin/teradata/ImplementAvgBigint.java
View file
Open in desktop

This file was deleted.

13 changes: 1 addition & 12 deletions plugin/trino-teradata/src/main/java/io/trino/plugin/teradata/LogonMechanism.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,11 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package io.trino.plugin.teradata;

/**
* Enum representing supported logon mechanisms for Teradata authentication.
* <p>
* Each mechanism corresponds to a specific authentication method
* such as TD2, JWT, BEARER, or SECRET.
* </p>
*/
public enum LogonMechanism
{
TD2("TD2"),
JWT("JWT"),
BEARER("BEARER"),
SECRET("SECRET");
TD2("TD2");

private final String mechanism;

Expand Down
Loading
Loading