Handled PR review comments#39
Closed
sc250072 wants to merge 468 commits into
Closed
Conversation
clearscape url Co-authored-by: Satish Chinthanippu <satish.chinthanippu@teradata.com>
Co-authored-by: Satish Chinthanippu <satish.chinthanippu@teradata.com>
Co-authored-by: Satish Chinthanippu <satish.chinthanippu@teradata.com>
Co-authored-by: Satish Chinthanippu <satish.chinthanippu@teradata.com>
Add developer documentation for Teradata Trino connector
Add comprehensive documentation for Teradata connector
Updated Teradata documentation
Added Java documentation for missed methods
# Conflicts: # plugin/trino-teradata/src/test/java/io/trino/plugin/integration/TeradataJdbcConnectorTest.java # plugin/trino-teradata/src/test/java/io/trino/plugin/integration/clearscape/BaseException.java # plugin/trino-teradata/src/test/java/io/trino/plugin/integration/clearscape/Error4xxException.java
Fixed github error prone check issues
I have made the changes as per comments in Trino Teradata initial PR
if (!this.hasBehavior) in teradataConnectorTest.java
Added comments to explain use of functions and they have been overridden
Merged AbstractTeradataJdbcTest.java into TestTeradataJdbcTypeMapping.java and renamed it to TestTeradataTypeMapping
Removed abbreviations from toWriteMapping
I have made the changes as per comments in Trino Teradata initial PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses review comments raised by the Trino team on trinodb/trino#26574. The changes improve the code and documentation based on feedback received during the review process.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( x) Release notes are required, with the following suggested text: