Ported models to 26.1.x#2637
Open
albazavr-alba wants to merge 19 commits into
Open
Conversation
Drullkus
requested changes
Jul 17, 2026
Member
There was a problem hiding this comment.
The removal of LichMinionModel, TrollsteinnModel, ReactorDebrisModel, RoyalRagsBuilder,RoyalRagsModel make no sense.
You said that you got the mod running on 26.1, right? Can you please post a screenshot of the Lich Minion, Trollsteinn block, Royal Rags, Artic Fur Block, all Giant Blocks, Moss Patch, Clover Patch, and Force Field blocks? These changes are unusually worse for reading and a lot overengineered.
albazavr-alba
marked this pull request as draft
July 17, 2026 10:27
albazavr-alba
force-pushed
the
port-models
branch
from
July 19, 2026 22:34
c05b053 to
dd0c26d
Compare
Author
|
I have fixed as many classes as I could. Unfortunately, I'm struggling to find the right approach for the rest. I think it would be best if someone with more expertise takes a look and fixes it |
albazavr-alba
marked this pull request as ready for review
July 20, 2026 00:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.