Ported overlays to 26.1.x#2634
Open
albazavr-alba wants to merge 2 commits into
Open
Conversation
a6tumn
reviewed
Jun 26, 2026
a6tumn
reviewed
Jun 26, 2026
a6tumn
suggested changes
Jun 26, 2026
a6tumn
reviewed
Jul 20, 2026
| .withDepthStencilState(new DepthStencilState(CompareOp.ALWAYS_PASS, false)) | ||
| .build(); | ||
| Material.Baked textureatlassprite = minecraft.getModelManager().getBlockStateModelSet().getParticleMaterial(TFBlocks.TWILIGHT_PORTAL.get().defaultBlockState()); | ||
| graphics.blit(pipeline, textureatlassprite.sprite().atlasLocation(), 0, 0, 0, 0, -90, window.getGuiScaledWidth(), window.getGuiScaledHeight(), ARGB.color(portal.getPortalTimer() / TFPortalAttachment.MAX_TICKS, 0, 0, 0)); |
There was a problem hiding this comment.
I want to preface this by saying that I am in no way an expert on graphics, but this color conversion does not look right to me. I believe that the old method was using normalized float channels between 0.0F-1.0F, which I think would now be equivalent to 0-255.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.