Repository navigation
[Fix] Issue-1089 Pin pnpm version and preserve corepack cache in Dockerfiles - #1090
Closed
Shivaansh-Agarwal wants to merge 1 commit into
Closed
Shivaansh-Agarwal wants to merge 1 commit into
Shivaansh-Agarwal wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Code reviewDiagnosis is right and the fix is minimal, but the pinning is only half-done. Note this PR is closed while Main points
Was this superseded by another PR, or just abandoned? If nothing replaced it, the |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Fixes #1089.
docker-compose up --buildcurrently fails/crash-loops because both Dockerfiles resolve pnpm to an unpinned "latest" version, which is incompatible with thenode:20-alpinebase image.packages/app/Dockerfile's cache cleanup step was removing the pinned pnpm version needed at container runtime.What type of PR is this? (Check all applicable)
Screenshots (if applicable)
Checklist