Skip to content

Convert Description to a record class#1486

Open
Isira-Seneviratne wants to merge 3 commits into
TeamNewPipe:devfrom
Isira-Seneviratne:Description-record
Open

Convert Description to a record class#1486
Isira-Seneviratne wants to merge 3 commits into
TeamNewPipe:devfrom
Isira-Seneviratne:Description-record

Conversation

@Isira-Seneviratne
Copy link
Copy Markdown
Member

  • Converted the Description value class to a record for conciseness.
  • Added a static of method to avoid redundant object creation for empty descriptions.
  • Added a Type enum for type safety.

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@sonarqubecloud
Copy link
Copy Markdown

@absurdlylongusername
Copy link
Copy Markdown
Member

If we are intending to convert the extractor to Kotlin in the near future, I don't think refactors such as this will hold much value as they will end up being redundant.

@Isira-Seneviratne
Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants