-
-
Notifications
You must be signed in to change notification settings - Fork 547
Feature/live chat comments #1481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Ecomont
wants to merge
19
commits into
TeamNewPipe:dev
Choose a base branch
from
Ecomont:feature/live-chat-comments
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
943a41f
Add bullet comments core framework
Ecomont 00b933f
Add YouTube bullet comments extractor
Ecomont b012ade
Add live chat fallback when comments are disabled
Ecomont cb82024
Add YoutubeLiveChatInfoItemExtractor
Ecomont 08f6570
Add isLiveChat flag to CommentsExtractor
Ecomont b782992
Update YoutubeCommentsExtractor for live chat pages
Ecomont 8a7cc39
Fix isCommentsDisabled to allow live chat
Ecomont 05a8d36
Mark live chat pages with live_chat identifier
Ecomont 620b756
Fix fetchLiveChat using replay endpoint on fresh extractors
Ecomont 40c54a7
Fix emoji extraction showing null for emoji-only messages
Ecomont 81b39fa
Improve custom emoji fallback handling
Ecomont fc533e4
Add debug logging to live chat polling
Ecomont 70c2734
Fix checkstyle violations in live chat and bullet comments code
Ecomont 9443929
Remove debug logging from live chat flow
Ecomont 3169692
Remove unused bullet comments code
Ecomont 05f6a5e
Separate live chat from comments extractor
Ecomont 2430540
Add tests for live chat functionality in YouTube extractors
Ecomont 84fa667
Remove unused isLiveStream flag from YoutubeCommentsExtractor
Ecomont 19892e7
Refactor emoji handling in live chat message extraction
Ecomont File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.