Feature/channel stream filter#13388
Closed
Ecomont wants to merge 76 commits intoTeamNewPipe:refactorfrom
Closed
Conversation
height x width was used before which is an uncommon order.
Currently translated at 2.2% (2 of 89 strings) Translated using Weblate (Georgian) Currently translated at 55.0% (49 of 89 strings) Translated using Weblate (Latvian) Currently translated at 97.9% (748 of 764 strings) Translated using Weblate (Georgian) Currently translated at 96.5% (738 of 764 strings) Co-authored-by: Flavjo Avdiu <flavjoavdiu10@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Nikoloz <nukushatugushi@gmail.com> Co-authored-by: ℂ𝕠𝕠𝕠𝕝 (𝕘𝕚𝕥𝕙𝕦𝕓.𝕔𝕠𝕞/ℂ𝕠𝕠𝕠𝕝) <coool@mail.lv> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ka/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sq/ Translation: NewPipe/Metadata
…agment Correctly retrieve menu item inside download dialog
Add warning banner about ongoing google certification for android apps
`getQuantity()` was being called in a couple of places with `zeroCaseStringId=0`, but that wasn't documented anywhere, and if `count==0` then `getString(zeroCaseStringId /* == 0 */)` would be returned which doesn't make sense
…onsistency Fix inconsistency in getQuantity and add docs
Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Greek) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Czech) Currently translated at 100.0% (89 of 89 strings) Translated using Weblate (Greek) Currently translated at 99.8% (764 of 765 strings) Translated using Weblate (Polish) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Estonian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Swedish) Currently translated at 96.6% (86 of 89 strings) Co-authored-by: Agnieszka C <aga_04@o2.pl> Co-authored-by: Fjuro <fjuro@users.noreply.hosted.weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Mickaël Binos <mickaelbinos@outlook.com> Co-authored-by: Mona Lisa <nickwick@users.noreply.hosted.weblate.org> Co-authored-by: Priit Jõerüüt <jrthwlate@users.noreply.hosted.weblate.org> Co-authored-by: Vasilis K. <skyhirules@gmail.com> Co-authored-by: delvani <del.cidrak@users.noreply.hosted.weblate.org> Co-authored-by: 大王叫我来巡山 <hamburger2048@users.noreply.hosted.weblate.org> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/cs/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sv/ Translation: NewPipe/Metadata
(cherry picked from commit 0020a02)
…to-release-0.28.4
Make error panel and error activity exception message URLs clickable via extension method Change ErrorMessage.getString to getText and return CharSequence, and use getText with formatArgs to preserve styling (i.e. URLs)
Currently translated at 97.9% (749 of 765 strings) Translated using Weblate (Latvian) Currently translated at 97.9% (749 of 765 strings) Translated using Weblate (Latvian) Currently translated at 18.8% (17 of 90 strings) Translated using Weblate (Latvian) Currently translated at 96.9% (742 of 765 strings) Translated using Weblate (Latvian) Currently translated at 97.3% (745 of 765 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Latvian) Currently translated at 17.7% (16 of 90 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Russian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Italian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Armenian) Currently translated at 31.6% (242 of 765 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Slovak) Currently translated at 76.6% (69 of 90 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Japanese) Currently translated at 13.3% (12 of 90 strings) Translated using Weblate (Czech) Currently translated at 100.0% (90 of 90 strings) Translated using Weblate (Korean) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (French) Currently translated at 98.8% (89 of 90 strings) Translated using Weblate (Japanese) Currently translated at 95.5% (731 of 765 strings) Translated using Weblate (Polish) Currently translated at 56.6% (51 of 90 strings) Translated using Weblate (Bulgarian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (90 of 90 strings) Translated using Weblate (Tamil) Currently translated at 48.8% (44 of 90 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (German) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (German) Currently translated at 100.0% (90 of 90 strings) Co-authored-by: 439JBYL80IGQTF25UXNR0X1BG <439jbyl80igqtf25uxnr0x1bg@users.noreply.hosted.weblate.org> Co-authored-by: Agnieszka C <aga_04@o2.pl> Co-authored-by: Davit Mayilyan <davit.mayilyan@protonmail.ch> Co-authored-by: Erenay <erenaydev@proton.me> Co-authored-by: Femini <nizamismidov4@gmail.com> Co-authored-by: Fjuro <fjuro@users.noreply.hosted.weblate.org> Co-authored-by: Ghost of Sparta <makesocialfoss32@keemail.me> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Mickaël Binos <mickaelbinos@outlook.com> Co-authored-by: Milan <mobrcian@hotmail.com> Co-authored-by: Random <random-r@users.noreply.hosted.weblate.org> Co-authored-by: Trunars <trunars@abv.bg> Co-authored-by: VfBFan <vfbfan@users.noreply.hosted.weblate.org> Co-authored-by: justcontributor <kty5663@gmail.com> Co-authored-by: kuragehime <kuragehime641@gmail.com> Co-authored-by: ssantos <ssantos@web.de> Co-authored-by: தமிழ்நேரம் <tamilneram247@gmail.com> Co-authored-by: ℂ𝕠𝕠𝕠𝕝 (𝕘𝕚𝕥𝕙𝕦𝕓.𝕔𝕠𝕞/ℂ𝕠𝕠𝕠𝕝) <coool@mail.lv> Co-authored-by: 大王叫我来巡山 <hamburger2048@users.noreply.hosted.weblate.org> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/cs/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/de/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ja/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/lv/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sk/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ta/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hans/ Translation: NewPipe/Metadata
Currently translated at 97.9% (749 of 765 strings) Translated using Weblate (Latvian) Currently translated at 97.9% (749 of 765 strings) Translated using Weblate (Latvian) Currently translated at 18.8% (17 of 90 strings) Translated using Weblate (Latvian) Currently translated at 96.9% (742 of 765 strings) Translated using Weblate (Latvian) Currently translated at 97.3% (745 of 765 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Latvian) Currently translated at 17.7% (16 of 90 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Russian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Italian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Armenian) Currently translated at 31.6% (242 of 765 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Slovak) Currently translated at 76.6% (69 of 90 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Japanese) Currently translated at 13.3% (12 of 90 strings) Translated using Weblate (Czech) Currently translated at 100.0% (90 of 90 strings) Translated using Weblate (Korean) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (French) Currently translated at 98.8% (89 of 90 strings) Translated using Weblate (Japanese) Currently translated at 95.5% (731 of 765 strings) Translated using Weblate (Polish) Currently translated at 56.6% (51 of 90 strings) Translated using Weblate (Bulgarian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (90 of 90 strings) Translated using Weblate (Tamil) Currently translated at 48.8% (44 of 90 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (German) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (German) Currently translated at 100.0% (90 of 90 strings) Co-authored-by: 439JBYL80IGQTF25UXNR0X1BG <439jbyl80igqtf25uxnr0x1bg@users.noreply.hosted.weblate.org> Co-authored-by: Agnieszka C <aga_04@o2.pl> Co-authored-by: Davit Mayilyan <davit.mayilyan@protonmail.ch> Co-authored-by: Erenay <erenaydev@proton.me> Co-authored-by: Femini <nizamismidov4@gmail.com> Co-authored-by: Fjuro <fjuro@users.noreply.hosted.weblate.org> Co-authored-by: Ghost of Sparta <makesocialfoss32@keemail.me> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Mickaël Binos <mickaelbinos@outlook.com> Co-authored-by: Milan <mobrcian@hotmail.com> Co-authored-by: Random <random-r@users.noreply.hosted.weblate.org> Co-authored-by: Trunars <trunars@abv.bg> Co-authored-by: VfBFan <vfbfan@users.noreply.hosted.weblate.org> Co-authored-by: justcontributor <kty5663@gmail.com> Co-authored-by: kuragehime <kuragehime641@gmail.com> Co-authored-by: ssantos <ssantos@web.de> Co-authored-by: தமிழ்நேரம் <tamilneram247@gmail.com> Co-authored-by: ℂ𝕠𝕠𝕠𝕝 (𝕘𝕚𝕥𝕙𝕦𝕓.𝕔𝕠𝕞/ℂ𝕠𝕠𝕠𝕝) <coool@mail.lv> Co-authored-by: 大王叫我来巡山 <hamburger2048@users.noreply.hosted.weblate.org> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/cs/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/de/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ja/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/lv/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sk/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ta/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hans/ Translation: NewPipe/Metadata
Currently translated at 70.0% (63 of 90 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (765 of 765 strings) Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Nicolás Pérez <nicoperez241@proton.me> Co-authored-by: Quý <quycodergithub@gmail.com> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/vi/ Translation: NewPipe/Metadata
…sue-url-sign-in-not-bot-exception Add link to FAQ entry to "Sign in to confirm not a bot" exception message
Currently translated at 94.9% (734 of 773 strings) Translated using Weblate (Estonian) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Vietnamese) Currently translated at 98.3% (760 of 773 strings) Translated using Weblate (Dutch) Currently translated at 99.0% (766 of 773 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Bulgarian) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Czech) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Italian) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Greek) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (German) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Turkish) Currently translated at 99.0% (766 of 773 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (French) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Polish) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Hindi) Currently translated at 98.9% (765 of 773 strings) Translated using Weblate (Korean) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Bulgarian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Somali) Currently translated at 73.3% (561 of 765 strings) Translated using Weblate (Latvian) Currently translated at 97.5% (746 of 765 strings) Translated using Weblate (Latvian) Currently translated at 97.6% (747 of 765 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (90 of 90 strings) Translated using Weblate (Hindi) Currently translated at 100.0% (90 of 90 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Hindi) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Turkish) Currently translated at 34.4% (31 of 90 strings) Translated using Weblate (Korean) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Romanian) Currently translated at 12.2% (11 of 90 strings) Translated using Weblate (Vietnamese) Currently translated at 99.3% (760 of 765 strings) Translated using Weblate (Vietnamese) Currently translated at 73.3% (66 of 90 strings) Translated using Weblate (Estonian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Italian) Currently translated at 100.0% (765 of 765 strings) Added translation using Weblate (Corsican) Translated using Weblate (Indonesian) Currently translated at 86.6% (78 of 90 strings) Translated using Weblate (German) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (French) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Indonesian) Currently translated at 99.7% (763 of 765 strings) Translated using Weblate (Greek) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Italian) Currently translated at 64.4% (58 of 90 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Czech) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Polish) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Polish) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Kabyle) Currently translated at 27.9% (214 of 765 strings) Translated using Weblate (German) Currently translated at 99.8% (764 of 765 strings) Co-authored-by: Agnieszka C <aga_04@o2.pl> Co-authored-by: ButterflyOfFire <boffire@users.noreply.hosted.weblate.org> Co-authored-by: Cabdi Waaxid Siciid <cabdiwaaxidsiciid100@gmail.com> Co-authored-by: David Bol <CapybarGooner2@proton.me> Co-authored-by: Dot Max <ahmadfadil.original@outlook.com> Co-authored-by: EESF-2 <eesf-2@users.noreply.hosted.weblate.org> Co-authored-by: Emin Tufan Çetin <etcetin@gmail.com> Co-authored-by: Erenay <erenaydev@proton.me> Co-authored-by: Femini <nizamismidov4@gmail.com> Co-authored-by: Fjuro <fjuro@users.noreply.hosted.weblate.org> Co-authored-by: Ghost of Sparta <makesocialfoss32@keemail.me> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Hosted Weblate user 142171 <traaduttore@users.noreply.hosted.weblate.org> Co-authored-by: Igor Rückert <igorruckert@yahoo.com.br> Co-authored-by: Jeff Huang <s8321414@gmail.com> Co-authored-by: Mickaël Binos <mickaelbinos@outlook.com> Co-authored-by: Milan <mobrcian@hotmail.com> Co-authored-by: Philip Goto <philip.goto@gmail.com> Co-authored-by: Priit Jõerüüt <jrthwlate@users.noreply.hosted.weblate.org> Co-authored-by: Quý <quycodergithub@gmail.com> Co-authored-by: Random <random-r@users.noreply.hosted.weblate.org> Co-authored-by: Stéphanie Olier <olier.stephanie130@gmail.com> Co-authored-by: TXRdev Archive <lckphanaf9999@gmail.com> Co-authored-by: Trunars <trunars@abv.bg> Co-authored-by: Vasilis K. <skyhirules@gmail.com> Co-authored-by: VfBFan <vfbfan@users.noreply.hosted.weblate.org> Co-authored-by: WB <wb@users.noreply.hosted.weblate.org> Co-authored-by: codetabsite <info.codetabteknofest@gmail.com> Co-authored-by: justcontributor <kty5663@gmail.com> Co-authored-by: rehork <cooky@e.email> Co-authored-by: ssantos <ssantos@web.de> Co-authored-by: whistlingwoods <72640314+whistlingwoods@users.noreply.github.com> Co-authored-by: ℂ𝕠𝕠𝕠𝕝 (𝕘𝕚𝕥𝕙𝕦𝕓.𝕔𝕠𝕞/ℂ𝕠𝕠𝕠𝕝) <coool@mail.lv> Co-authored-by: 大王叫我来巡山 <hamburger2048@users.noreply.hosted.weblate.org> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/hi/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/id/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/it/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pa/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ro/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/tr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/vi/ Translation: NewPipe/Metadata
Use getApplicationContext() instead of getContext() in ENQUEUE, ENQUEUE_NEXT, START_HERE_ON_BACKGROUND, and START_HERE_ON_POPUP entries to prevent NullPointerException when the fragment's activity context becomes null during configuration changes (e.g. device rotation). The fragment context can become null when the activity is destroyed during rotation, but the async callback from fetchItemInfoIfSparse still holds a reference to the now-detached fragment. Using Application context ensures a stable, non-null context throughout the async operation lifecycle.
Delete untranslated locales
…on-context-for-enqueue Fix NullPointerException in enqueue actions by using Application Context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
setHasOptionsMenu(true)inChannelTabFragmentto dynamically inject the standard "Eyeball" visibility toggle icon specifically within the Streams tab.showStreamVisibilityDialog()and the existingfeed_show_watched_items_keySharedPreferences to maintain a cohesive user experience with the main feed.loadResult()andloadMoreItemsLogic()using.map()to apply the filter asynchronously off-thread, preventing UI frame drops.shouldIncludeItem()to query theHistoryRecordManagerfor local watch states, evaluatingisFinished()andisValid()based on the user's preferences.Collections.unmodifiableListconstraint fromNewPipeExtractorby creating a filtered list and updating it viainfo.setRelatedItems(filteredItems), safely dropping unwatched/watched streams.Before/After Screenshots/Screen Record
- After:
screencast2.mp4
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.