Skip to content

Normalize iCal line endings to CRLF#227

Merged
kordianbruck merged 2 commits intomasterfrom
seer/fix/ical-crlf-normalization
Apr 15, 2026
Merged

Normalize iCal line endings to CRLF#227
kordianbruck merged 2 commits intomasterfrom
seer/fix/ical-crlf-normalization

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry Bot commented Apr 15, 2026

Fixes CALENDARPROXY-1. The issue was that: golang-ical's Serialize() uses LF instead of CRLF, causing Content-Length mismatch and client-side connection closure.

  • Normalize line endings in serialized iCal data to CRLF (\r\n).
  • Ensure compliance with RFC 5545 for calendar data.
  • Prevent double carriage returns by first replacing existing CRLF with LF, then all LF with CRLF.

This fix was generated by Seer in Sentry, triggered by kordianbruck. 👁️ Run ID: 1153191

Not quite right? Click here to continue debugging with Seer.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses CALENDARPROXY-1 by ensuring serialized iCalendar output uses CRLF (\r\n) line endings (per RFC 5545), avoiding downstream Content-Length mismatches and client disconnects.

Changes:

  • Normalize golang-ical serialized output from LF to CRLF.
  • Avoid double-CR issues by converting existing CRLF to LF before converting all LF to CRLF.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/app.go Outdated
Copilot AI requested a review from kordianbruck April 15, 2026 15:19
@kordianbruck kordianbruck marked this pull request as ready for review April 15, 2026 15:19
@kordianbruck kordianbruck merged commit 1f595f9 into master Apr 15, 2026
3 checks passed
@kordianbruck kordianbruck deleted the seer/fix/ical-crlf-normalization branch April 15, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants