Fix exporting of module function in Bash#829
Merged
Merged
Conversation
15b5772 introduced a helper method `__lmod_internal_module_cmd`, however this is not exported. Hence on subshells `module` and `ml` is defined but call the non-existing `__lmod_internal_module_cmd` function and fail.
Member
|
Thanks very much for the patch! |
Contributor
|
@rtmclay Would be nice to have a quick new release with this fix included... |
Member
|
Lmod 9.2.4 is now released with this PR. |
4 tasks
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jun 16, 2026
This version contained a bug on cluster login nodes. See-also: TACC/Lmod#829 Signed-off-by: Alexander Puck Neuwirth <apn-pucky@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
15b5772 introduced a helper method
__lmod_internal_module_cmd, however this is not exported. Hence on subshellsmoduleandmlis defined but call the non-existing__lmod_internal_module_cmdfunction and fail.