fix: attempt to fix "Fetching source account data timed out" error.#216
Open
troggy wants to merge 1 commit into
Open
fix: attempt to fix "Fetching source account data timed out" error.#216troggy wants to merge 1 commit into
troggy wants to merge 1 commit into
Conversation
Hypotesis is the "issued assets" fetching is done in the same request that fetches sequence_no for the source account in Payment Form is slow for some reason. The request itself is absolutely unnecessary in this case. Short term workaround implemented here: add a flag to skip issued accounts fetching in some cases Long term solution: remake issued account fetching to be separate request that populates "asset list" when it is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hypothesis is the "issued assets" fetching is done in the same request that fetches sequence_no for the source account in Payment Form is slow for some reason. The request itself is absolutely unnecessary in this case.
Short term workaround implemented here: add a flag to skip issued accounts fetching in some cases
Long term solution: remake issued account fetching to be separate request that populates "asset list" when it is needed