feat: add Picture-in-Picture mode via system tray toggle#34
Open
kaydorbz wants to merge 1 commit intoStremio:mainfrom
Open
feat: add Picture-in-Picture mode via system tray toggle#34kaydorbz wants to merge 1 commit intoStremio:mainfrom
kaydorbz wants to merge 1 commit intoStremio:mainfrom
Conversation
- Add toggle_pip to WindowStyle (always-on-top, 400x225, no resize, draggable) - Add PiP menu item to system tray with checkmark state - Add Cell<bool> pip_mode to bypass min_max constraints during PiP - Restore full window on PiP exit - Closes Stremio/stremio-shell#460
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picture-in-Picture Mode
Adds PiP support to the desktop shell via the system tray menu.
What it does
Implementation
window_helper.rs: Newtoggle_pip()method onWindowStyle— saves/restores window state, applies PiP style (no thick frame, always-on-top, 400×225)app.rs:on_toggle_pip_noticehandler,Cell<bool>forpip_modeto avoid RefCell borrow conflicts duringWM_GETMINMAXINFOsystray.rs: "Picture in Picture" menu item with checkmarkCloses
Testing
stremio-shell-ng.exe+ MPV playback