Skip to content

build: bump workspace MSRV from 1.77 to 1.85 #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anikettuli wants to merge 1 commit into from
Closed

build: bump workspace MSRV from 1.77 to 1.85 #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/msrv.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ concurrency:
cancel-in-progress: true

env:
RUST_MSRV_VERSION: '1.77'
RUST_MSRV_VERSION: '1.85'

jobs:
build:
Expand Down
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ version = "0.1.0"
authors = ["Smart Code OOD"]
edition = "2021"

# When upgrading MSRV make sure to update the msrv.yaml workflow
rust-version = "1.77"
# When upgrading MSRV make sure to update the msrv.yml workflow
rust-version = "1.85"
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping the workspace MSRV to 1.85 will likely break existing CI jobs/toolchains that are still pinned to Rust 1.77 (e.g. stremio-core-web/rust-toolchain.toml and the RUST_VERSION: '1.77' env vars in several workflows). Those jobs build stremio-core-web, which depends on stremio-core; Cargo will refuse to compile it with a toolchain lower than stremio-core’s rust-version. Consider updating those pins (or otherwise adjusting the CI matrix) so the whole repo builds consistently after this MSRV bump.

Suggested change
rust-version = "1.85"
rust-version = "1.77"

Copilot uses AI. Check for mistakes.

[profile.release]
lto = true
Expand Down
5 changes: 3 additions & 2 deletions stremio-watched-bitfield/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ version = "0.1.0"
edition = "2021"
publish = false

# because of `dep:serde` supported after 1.60
rust-version = "1.60"
# Aligned with the workspace MSRV. Originally pinned at 1.60 for `dep:serde`
# syntax; raising to 1.85 keeps all three crates on one Rust version.
Comment on lines +7 to +8
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says raising to 1.85 “keeps all three crates on one Rust version”, but other workspace crates (e.g. stremio-core-web, stremio-derive) currently don’t declare rust-version, so this statement is misleading. Either adjust the wording to reflect what’s actually enforced, or add rust-version = "1.85" to the other workspace crates to truly align declared MSRV across the workspace.

Suggested change
# Aligned with the workspace MSRV. Originally pinned at 1.60 for `dep:serde`
# syntax; raising to 1.85 keeps all three crates on one Rust version.
# Aligned with the workspace-targeted Rust version. Originally pinned at
# 1.60 for `dep:serde` syntax; this crate now declares Rust 1.85.

Copilot uses AI. Check for mistakes.
rust-version = "1.85"

[lib]
doctest = false
Expand Down
Loading