fix: map subtitle label field in protobuf bridge#110
Open
schobiDotDev wants to merge 1 commit intoStremio:masterfrom
Open
fix: map subtitle label field in protobuf bridge#110schobiDotDev wants to merge 1 commit intoStremio:masterfrom
schobiDotDev wants to merge 1 commit intoStremio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #109
Problem
stremio-core#947 (v0.55.0) added a
label: Option<String>field to theSubtitlesstruct, allowing addons to provide custom display names for subtitle tracks. However, the protobuf bridge doesn't map this field, so Android/Android TV apps never receive it.Currently, the protobuf
namefield (field 4) is populated with the addon name viaaddon_name.cloned(), not the subtitle's own label.Changes
optional string label = 5to theSubtitlemessageSubtitles.labelto the new protobuflabelfield in bothToProtobufandFromProtobuf9a827fddtob5d3833fto pick up thelabelfield on theSubtitlesstructThe existing
namefield (field 4) is left unchanged - it continues to carry the addon name. The newlabelfield (field 5) is additive and backward compatible.Related
labeltoSubtitlestypeAndroid app follow-up
Once this bridge change is merged, the Android app's subtitle picker would need to prefer
labelover the resolvedlangname for variant display. Since the app is closed source, this would be handled by the Stremio team.