Conversation
This commit brings in the mission support features from PR 49 by kashish srivatsav while keeping the codebase aligned with upstream/main.
|
@kashish2210 I've have Worked up on your Draft PR #49 ! |
|
Ohh great @Omiii-215 |
| calculate_event_properties, | ||
| extract_metadata, | ||
| create_lightcurve, | ||
| rebin |
There was a problem hiding this comment.
Why you have removed this exports ??
Revert this
| calculate_errors!(filtered_lc) | ||
|
|
||
| return filtered_lc | ||
| end |
| times, dt, counts, nothing, nothing, EventProperty{Float64}[], | ||
| metadata, :poisson | ||
| ) | ||
| end |
| @test filtered_lc.metadata.extra["gti_index"] == 1 | ||
| @test filtered_lc.metadata.extra["filtered_nbins"] == 3 | ||
| @test filtered_lc.metadata.extra["original_nbins"] == 5 | ||
| end |
There was a problem hiding this comment.
Don't remove implemented functions ;)
|
So @Omiii-215 thanks for your PR i appreciate it but ig u have accidentally removed existing functionalities from this the minal changes can be done in readevent function only to use it |
|
Thanks I'm Still learning, @kashish2210! My branch got out of sync with upstream/main during development. When I pulled in the latest changes to resolve merge conflicts, Git accidentally re-applied some old deletions from my branch over the newly added lightcurve.jl features. I've just pushed a fix that cleanly restores all the missing LightCurve dependencies, tests, and upstream GTI handling back into readevents. I also refactored my Mission Support additions to be minimal integrations within readevents, as you suggested. Everything is passing locally now |
| path::AbstractString; | ||
| mission::Union{String,Nothing} = nothing, | ||
| instrument::Union{String,Nothing} = nothing, | ||
| epoch::Union{Float64,Nothing} = nothing, |
| gti_end = @view gti[:, 2] | ||
|
|
||
| if any(gti_end < gti_start) | ||
| if any(gti_end .< gti_start) |
|
Great work @Omiii-215 ! |
2 participants
MissionSupport.jlimplementation from PR Mission support #49 (kashish srivatsav), allowing dynamic PI-to-Energy calibration parsing based on telescope specs.readeventsto handlemission,instrument, andepocharguments while applying calibration data dynamically.LightCurvedependencies and matched test_events.jl / test_missionSupport.jl with upstreamFITSMetadataconstructions.