Repository navigation
chore: move to start-sdk 3.0.3; 0.3.5:0 → 0.3.5:1 - #41
Conversation
- pin start-sdk 3.0.3, drop the toolchain the SDK supplies, use the SDK prettier config, rebuild the lock - sync workflows to the template (ready_for_review, pr-retarget.yml) on main - store.json shape is z.looseObject - lnd moves to a required sdk.Dependency in dependencies.ts; the version-gated onion-messages task moves to withInit unchanged; range >=0.21.1-beta:4 verified against lnd's history - Set Primary URL uses sdk.setupPrimaryUrl (same id, store key, fallback: false); main and Open UI use bestUsable; the critical task is still raised only when a chosen URL is gone, and now clears when it returns - emulateMissing: false on the image - LND dependency description and instructions no longer claim LND 0.20 support - resync AGENTS.md; update README, instructions; fix UPDATING.md dead link Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
helix-a
left a comment
There was a problem hiding this comment.
Reviewed 887f0b2 against main: no blocking correctness findings. The SDK migration preserves the primary-URL action/storage identity and opt-in setup; task clearing and the required LND declaration are consistent with SDK 3.0.3. That pin matches the latest npm release.
Verified clean merge-tree and diff checks; cache-backed npm ci and make passed for x86_64 and aarch64, including SDK gates. The lock stayed unchanged after npm install, with one deduplicated SDK copy. Inspected both returned s9pks for version, head hash, dependency requirements, and architecture. Both architecture CI jobs passed. Runtime behavior was reviewed in source, not exercised on a running StartOS service.
One description correction: the obsolete onion-messages task is removed and cleared, not moved unchanged into withInit. This is consistent with the existing LND floor.
Helix-Harness: pi
Helix-Model: openai-codex/gpt-6.1-sol
The SDK 3.0.3 migration for BOLT12 Pay, plus the primary-URL behavior it makes available.
npm audit0), with one SDK copy shared withlnd-startos#next. The toolchain the SDK now supplies is dropped, and.prettierrcnames the SDK's shared config.store.jsonisz.looseObject. Under 3.0.x az.objectshape would drop any key it doesn't declare on the next write.sdk.Dependencyindependencies.ts, passed tobuildManifestandsetupInit. The version-gated onion-messages task moves intowithInitunchanged. The range>=0.21.1-beta:4was checked against LND's history: thecontrol/grpchosts this package imports exist from0.21.1-beta:1, and REST runs without certificate verification, so nothing newer is needed.sdk.setupPrimaryUrlwith the same action id andstore.jsonkey, so existing choices carry over.fallback: false: with no choice, the app gets no LNURL defaults, as before, rather than a.localbase.preferredLauncherAddress) when the viewer's connection can reach it.criticaltask when a chosen URL disappears. It now clears itself when the address returns.emulateMissing: falseon the image.instructions.mdsaid LND 0.20 works. The published range and the imported host ids require 0.21.1 or newer.UPDATING.mdlinked a non-existentCONTRIBUTING.md.main(ready_for_review,pr-retarget.yml);AGENTS.mdresynced, README and instructions updated.🤖 Generated with Claude Code