Skip to content

chore: move to start-sdk 3.0.3; 0.3.5:0 → 0.3.5:1 - #41

Merged
MattDHill merged 1 commit into
mainfrom
chore/sdk-3
Oct 8, 2026
Merged

MattDHill merged 1 commit into
mainfrom
chore/sdk-3

Conversation

@MattDHill

Copy link
Copy Markdown
Member

The SDK 3.0.3 migration for BOLT12 Pay, plus the primary-URL behavior it makes available.

  • start-sdk 3.0.3. The lock is resolved against the live registry (npm audit 0), with one SDK copy shared with lnd-startos#next. The toolchain the SDK now supplies is dropped, and .prettierrc names the SDK's shared config.
  • store.json is z.looseObject. Under 3.0.x a z.object shape would drop any key it doesn't declare on the next write.
  • LND is a required sdk.Dependency in dependencies.ts, passed to buildManifest and setupInit. The version-gated onion-messages task moves into withInit unchanged. The range >=0.21.1-beta:4 was checked against LND's history: the control/grpc hosts this package imports exist from 0.21.1-beta:1, and REST runs without certificate verification, so nothing newer is needed.
  • Set Primary URL uses sdk.setupPrimaryUrl with the same action id and store.json key, so existing choices carry over.
    • fallback: false: with no choice, the app gets no LNURL defaults, as before, rather than a .local base.
    • A chosen hostname that moves to another port is followed.
    • Open UI prefers the chosen URL (preferredLauncherAddress) when the viewer's connection can reach it.
    • The task keeps the package's design: none on a fresh install, since LNURL is opt-in, and a critical task when a chosen URL disappears. It now clears itself when the address returns.
  • emulateMissing: false on the image.
  • Fixes:
    • The LND dependency description (all locales) and instructions.md said LND 0.20 works. The published range and the imported host ids require 0.21.1 or newer.
    • The Set Primary URL description said changes apply on the next restart; the service restarts by itself.
    • UPDATING.md linked a non-existent CONTRIBUTING.md.
  • Workflows synced to the package template on main (ready_for_review, pr-retarget.yml); AGENTS.md resynced, README and instructions updated.

🤖 Generated with Claude Code

- pin start-sdk 3.0.3, drop the toolchain the SDK supplies, use the SDK prettier config, rebuild the lock
- sync workflows to the template (ready_for_review, pr-retarget.yml) on main
- store.json shape is z.looseObject
- lnd moves to a required sdk.Dependency in dependencies.ts; the version-gated onion-messages task moves to withInit unchanged; range >=0.21.1-beta:4 verified against lnd's history
- Set Primary URL uses sdk.setupPrimaryUrl (same id, store key, fallback: false); main and Open UI use bestUsable; the critical task is still raised only when a chosen URL is gone, and now clears when it returns
- emulateMissing: false on the image
- LND dependency description and instructions no longer claim LND 0.20 support
- resync AGENTS.md; update README, instructions; fix UPDATING.md dead link

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MattDHill
MattDHill requested a review from helix-a October 8, 2026 03:18

@helix-a helix-a left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 887f0b2 against main: no blocking correctness findings. The SDK migration preserves the primary-URL action/storage identity and opt-in setup; task clearing and the required LND declaration are consistent with SDK 3.0.3. That pin matches the latest npm release.

Verified clean merge-tree and diff checks; cache-backed npm ci and make passed for x86_64 and aarch64, including SDK gates. The lock stayed unchanged after npm install, with one deduplicated SDK copy. Inspected both returned s9pks for version, head hash, dependency requirements, and architecture. Both architecture CI jobs passed. Runtime behavior was reviewed in source, not exercised on a running StartOS service.

One description correction: the obsolete onion-messages task is removed and cleared, not moved unchanged into withInit. This is consistent with the existing LND floor.

Helix-Harness: pi
Helix-Model: openai-codex/gpt-6.1-sol

@MattDHill
MattDHill merged commit acb91d9 into main Oct 8, 2026
3 checks passed
@MattDHill
MattDHill deleted the chore/sdk-3 branch October 8, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants