Request read:org scope so starkast membership is visible#1010
Merged
Conversation
Assemble the GitHub OAuth authorize query from a list of key=value pairs instead of one long interpolated string. Behaviour is unchanged; redirect_uri stays un-re-encoded since request.referrer is already percent-encoded.
starkast? checks org membership via GET /orgs/starkast/members/:login. That endpoint only returns 204 when the OAuth token can read org membership; with the previous user:email-only scope GitHub answered 302 and every user read as non-starkast, so private pages and the conceal toggle were unusable in production. Adding read:org makes the check return 204 for members, public or private. Existing users get a one-time GitHub re-authorization prompt on next login because the requested scope changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.