[BugFix] Fix query cache conflicts local shuffle agg#73194
Conversation
Query cache require assign tablet to per drivers. But local shuffle agg will blocking cannot work without could_local_shufle=false. Signed-off-by: stdpain <drfeng08@gmail.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e094cba60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| CONCAT('cat-', CAST(generate_series % 10 AS STRING)) | ||
| FROM TABLE(generate_series(1, 1000)); | ||
|
|
||
| SELECT category, COUNT(*) FROM t1 GROUP BY category ORDER BY category limit 10; No newline at end of file |
There was a problem hiding this comment.
This test never turns on query cache and executes the aggregate query only once, so it does not exercise the cache populate/probe path that the fix targets; enable_query_cache is false by default, which means the local-shuffle/query-cache interaction is not validated here. As written, the case can pass even if the original conflict still exists, so it should explicitly enable query cache (for example with SET_VAR) and rerun the same query to force a cache hit path.
Useful? React with 👍 / 👎.
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 3 / 3 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
4 participants
Why I'm doing:
Query cache require assign tablet to per drivers. But local shuffle agg will blocking cannot work without could_local_shufle=false.
In this patch we disable the local shuffle agg when enable the query cache.
What I'm doing:
Fixes #73183
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: