[BugFix] Relax DB lock to intensive path in qe/ read-only paths by kevincai · Pull Request #73067 · StarRocks/starrocks

kevincai · 2026-05-11T01:48:56Z

Switch four single-table read paths in qe/ from full DB READ to IS+table-READ via lockTableWithIntensiveDbLock so they no longer block concurrent DDL on other tables in the same database.

ShowExecutor.showCreateInternalCatalogTable: move lookup outside the lock; revalidate the resolved Table reference once the intensive lock is held so concurrent DROP/RENAME between lookup and lock acquisition is reported as ERR_BAD_TABLE_ERROR rather than serving DDL from a stale Table.
ShowExecutor.visitShowTabletStatement (both branches): use the known/resolved tableId for table-READ; the table-by-name branch also revalidates after locking. The single-tablet branch already re-fetches under the lock and needs no extra check.
ConnectProcessor.handleFieldList: move lookup outside the lock; collapse the nested lock-try inside the connector-exception try into a single try-catch-finally; revalidate after locking for internal-catalog DBs (external catalog tables are not tracked by LocalMetastore).

The revalidation closes a TOCTOU window: under the old DB READ, DROP/RENAME could not interleave between lookup and use; under IS+table-READ the lookup is unprotected so the resolved Table can be removed from the DB before the lock is taken. Re-fetching by id after locking and comparing references catches that window and reports the table as not-found, matching the old semantics.

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
- This pr needs auto generate documentation
This is a backport pr

Bugfix cherry-pick branch check:

Switch four single-table read paths in qe/ from full DB READ to IS+table-READ via lockTableWithIntensiveDbLock so they no longer block concurrent DDL on other tables in the same database. - ShowExecutor.showCreateInternalCatalogTable: move lookup outside the lock; revalidate the resolved Table reference once the intensive lock is held so concurrent DROP/RENAME between lookup and lock acquisition is reported as ERR_BAD_TABLE_ERROR rather than serving DDL from a stale Table. - ShowExecutor.visitShowTabletStatement (both branches): use the known/resolved tableId for table-READ; the table-by-name branch also revalidates after locking. The single-tablet branch already re-fetches under the lock and needs no extra check. - ConnectProcessor.handleFieldList: move lookup outside the lock; collapse the nested lock-try inside the connector-exception try into a single try-catch-finally; revalidate after locking for internal-catalog DBs (external catalog tables are not tracked by LocalMetastore). The revalidation closes a TOCTOU window: under the old DB READ, DROP/RENAME could not interleave between lookup and use; under IS+table-READ the lookup is unprotected so the resolved Table can be removed from the DB before the lock is taken. Re-fetching by id after locking and comparing references catches that window and reports the table as not-found, matching the old semantics. Signed-off-by: Kevin Cai <kevin.cai@celerdata.com>

CelerData-Reviewer · 2026-05-11T01:49:50Z

@codex review

chatgpt-codex-connector · 2026-05-11T01:55:03Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-05-11T03:40:43Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2026-05-11T03:41:54Z

[FE Incremental Coverage Report]

❌ fail : 25 / 56 (44.64%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/qe/ShowExecutor.java	16	43	37.21%	[868, 869, 873, 874, 875, 876, 877, 878, 879, 880, 881, 882, 883, 885, 886, 890, 891, 892, 893, 894, 895, 896, 901, 913, 1992, 2002, 2003]
🔵	com/starrocks/qe/ConnectProcessor.java	9	13	69.23%	[787, 788, 789, 790]

github-actions · 2026-05-11T03:44:03Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

Copilot

Pull request overview

This PR reduces lock contention in FE qe/ read-only code paths by replacing full DB READ locks with “intensive” locking (IS + table-READ) for single-table operations, so concurrent DDL on other tables in the same DB is less likely to be blocked.

Changes:

Updated SHOW CREATE TABLE (internal catalog) to lock via lockTableWithIntensiveDbLock, with a post-lock revalidation step intended to detect DROP/RENAME races.
Updated SHOW TABLET to use per-table intensive locks (both single-tablet and table-by-name branches), with post-lock revalidation in the table-by-name branch.
Updated COM_FIELD_LIST handling to perform metadata lookup outside the lock and then lock via lockTableWithIntensiveDbLock, with internal-catalog revalidation after locking.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java	Switches select SHOW read paths from DB READ to IS+table-READ and adds post-lock revalidation for TOCTOU safety.
fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java	Adjusts COM_FIELD_LIST to use table-level intensive locking and restructures lookup/exception handling with revalidation for internal catalog.

github-actions · 2026-05-13T03:08:59Z

@Mergifyio backport branch-4.0

github-actions · 2026-05-13T03:09:05Z

@Mergifyio backport branch-4.1

mergify · 2026-05-13T03:09:27Z

backport branch-4.0

✅ Backports have been created

Details

#73189 [BugFix] Relax DB lock to intensive path in qe/ read-only paths (backport #73067) has been created for branch branch-4.0 but encountered conflicts

Cherry-pick of c15972b has failed:

On branch mergify/bp/branch-4.0/pr-73067
Your branch is up to date with 'origin/branch-4.0'.

You are currently cherry-picking commit c15972b5ad.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify · 2026-05-13T03:09:28Z

backport branch-4.1

✅ Backports have been created

Details

#73190 [BugFix] Relax DB lock to intensive path in qe/ read-only paths (backport #73067) has been created for branch branch-4.1

…port #73067) (#73189) Signed-off-by: Kevin Cai <kevin.cai@celerdata.com> Co-authored-by: Kevin Cai <kevin.cai@celerdata.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kevincai <771299+kevincai@users.noreply.github.com>

…port #73067) (#73190) Signed-off-by: Kevin Cai <kevin.cai@celerdata.com> Co-authored-by: Kevin Cai <kevin.cai@celerdata.com>

github-actions Bot added 4.0 4.1 labels May 11, 2026

mergify Bot assigned kevincai May 11, 2026

github-actions Bot requested a review from HangyuanLiu May 11, 2026 01:51

kevincai requested review from Copilot, gengjun-git and wyb May 11, 2026 07:21

Copilot started reviewing on behalf of kevincai May 11, 2026 07:22 View session

Copilot AI reviewed May 11, 2026

View reviewed changes

Comment thread fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java

Comment thread fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java

kevincai requested a review from starrocks-xupeng May 12, 2026 02:54

gengjun-git self-assigned this May 12, 2026

wyb approved these changes May 12, 2026

View reviewed changes

gengjun-git approved these changes May 13, 2026

View reviewed changes

huailiu1122 merged commit c15972b into StarRocks:main May 13, 2026
111 of 116 checks passed

github-actions Bot removed the 4.0 label May 13, 2026

kevincai deleted the bugfix/db-lock-relax-connect-show-executor branch May 13, 2026 03:09

github-actions Bot removed the 4.1 label May 13, 2026

This was referenced May 13, 2026

[BugFix] Relax DB lock to intensive path in qe/ read-only paths (backport #73067) #73189

Merged

[BugFix] Relax DB lock to intensive path in qe/ read-only paths (backport #73067) #73190

Merged

github-actions Bot added the 4.0-merged label May 13, 2026

wanpengfei-git pushed a commit that referenced this pull request May 13, 2026

[BugFix] Relax DB lock to intensive path in qe/ read-only paths (back…

d351ac3

…port #73067) (#73190) Signed-off-by: Kevin Cai <kevin.cai@celerdata.com> Co-authored-by: Kevin Cai <kevin.cai@celerdata.com>

github-actions Bot added the 4.1-merged label May 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Relax DB lock to intensive path in qe/ read-only paths#73067

[BugFix] Relax DB lock to intensive path in qe/ read-only paths#73067
huailiu1122 merged 1 commit into
StarRocks:mainfrom
kevincai:bugfix/db-lock-relax-connect-show-executor

kevincai commented May 11, 2026

Uh oh!

CelerData-Reviewer commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 11, 2026

Uh oh!

github-actions Bot commented May 11, 2026

Uh oh!

github-actions Bot commented May 11, 2026

Uh oh!

github-actions Bot commented May 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

mergify Bot commented May 13, 2026 •

edited

Loading

Uh oh!

mergify Bot commented May 13, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

kevincai commented May 11, 2026

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Uh oh!

CelerData-Reviewer commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 11, 2026

Uh oh!

github-actions Bot commented May 11, 2026

[Java-Extensions Incremental Coverage Report]

Uh oh!

github-actions Bot commented May 11, 2026

[FE Incremental Coverage Report]

file detail

Uh oh!

github-actions Bot commented May 11, 2026

[BE Incremental Coverage Report]

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

mergify Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

mergify Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mergify Bot commented May 13, 2026 •

edited

Loading

mergify Bot commented May 13, 2026 •

edited

Loading