[BugFix] Resolve inconsistent global dictionary generation in flat JSON#72953
Conversation
The heterogeneous JSON detection logic did not correctly handle cases where: a load batch did not generate a dictionary a JSON path was extracted as a non-string type (such as int) As a result, later dictionary collection could incorrectly ignore these values, causing dictionary loss and inconsistency across loads. Signed-off-by: stdpain <drfeng08@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4de1df92bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com>
Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com>
Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com>
Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com>
Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com>
Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 3 / 3 (100.00%) file detail
|
|
@Mergifyio backport branch-4.1 |
✅ Backports have been createdDetails
Cherry-pick of 4c8f9c6 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Why I'm doing:
The heterogeneous JSON detection logic did not correctly handle cases where:
a load batch did not generate a dictionary
a JSON path was extracted as a non-string type (such as int)
As a result, later dictionary collection could incorrectly ignore these values, causing dictionary loss and inconsistency across loads.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: