Merged
Conversation
Collaborator
Author
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
There is no way to persist a
CaptionResultto disk.⚙️ Release Notes
exporters/package withlean.py:write_caption_result(result, path, *, rows_per_shard=4096, compression="zstd")recordings_{i:04d}.arrow), one shard perrows_per_shardrecordings — ~32 shards for the full MHC dataset at the default, a single shard for typical small exportssensortslm.schema_versionin each shard's schema metadata — no separate manifest filemmapreads downstream, and our access pattern is whole-row (parquet's column-pruning advantage doesn't apply)📚 Documentation
Public API is documented inline. Usage:
The
exporters/package uses an empty__init__.pyso future format modules (e.g.exporters/timenet.py) can be added without forcing every consumer to load all formats' dependencies.✅ Testing
Smoke-tested on the local MHC subset (
../mhc_subset_testdata_hf) in thesensortslm3.12 venv:exports/lean_smokewithrows_per_shard=2to force the multi-shard path → got 3 shards (~75 KB total)annotationsstruct listsensortslm.schema_version=1round-trips viafeather.read_table(...).schema.metadataRecordingreconstruction (round-trip via a temporary read helper) preservesrow_id,channel_names,values(NaN-aware),has_any_data, and all annotation fieldsCode of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: