refactor: Code cleanup Pt3#39
Merged
Merged
Conversation
Ninerian
commented
Oct 29, 2025
Ninerian
commented
Contributor
- raised phpstan level to 8 and fixed all issues
- Updated phpstan.neon.dist to level 8 - Added null checks for ReflectionClass::getConstructor() calls in test files - Enhanced PluginSession to handle nullable instanceId parameter - Used PHP 8+ null coalescing throw operator for clean error handling - Improved null safety across test and source files Key improvements: - All ReflectionMethod calls now safely handle null returns - deleteInstance method properly validates required instanceId parameter - Modern PHP syntax for null safety with descriptive error messages - No breaking changes to existing functionality 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.