Repository navigation
Bard skills fail when the instrument is played badly - #1637
Merged
mtwango merged 2 commits intoOct 22, 2026
Merged
Conversation
Use_PlayMusic returns -2 without an instrument and -1 when the Musicianship check fails, but Peacemaking, Provocation
and Enticement aborted only on -2 ("< -1"): with a bad play they went on as if the music was good. They now fail
on both.
Since a failed attempt aborts the skill with no delay, the Musicianship check made by these skills doesn't give
Musicianship gains anymore (it could be macroed). Musicianship used by itself is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use_PlayMusic returns -2 without an instrument and -1 when the Musicianship check fails, but Peacemaking, Provocation and Enticement aborted only on -2 ("< -1"): with a bad play they went on as if the music was good. They now fail on both.
Since a failed attempt aborts the skill with no delay, the Musicianship check made by these skills doesn't give Musicianship gains anymore (it could be macroed). Musicianship used by itself is unchanged.
Type of Change
Related Issues
None.
Testing
Checklist
Additional Notes
This changes an existing behaviour: it's a proposal, feel free to discuss or ask for changes (an ini switch, a flag...).
🤖 Generated with Claude Code