Silence Apple Accelerate header warnings via system_header pragma#106
Merged
Conversation
Apple's Accelerate/LAPACK/Sparse headers (pulled in through ACCELERATE_NEW_LAPACK) trip a large, SDK-version-dependent set of -Wpedantic/GNU-extension warnings: _Nullable/_Nonnull nullability qualifiers, zero-arg variadic macros, extra semicolons, and more. On the Xcode SDK this floods the build with tens of thousands of warnings from headers we cannot fix. Mark the Accelerate include as a system header with `#pragma clang system_header` so all of its warnings are suppressed regardless of which flag or SDK version produces them, while our own code keeps full -Wpedantic strictness. cblas_wrapper.h contains nothing but the include, so the marker is effectively scoped to Accelerate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Transurgeon
approved these changes
Jul 12, 2026
Transurgeon
left a comment
Transurgeon
left a comment
Member
There was a problem hiding this comment.
nice! let me know if I should merge this.
I don't really know what #pragma does or what the word even means haha.
Collaborator
Author
|
merged :) This was just to disable some warnings outside our src code (inside lapack/blas) that showed when I compiled the code |
Transurgeon
pushed a commit
that referenced
this pull request
Jul 13, 2026
Apple's Accelerate/LAPACK/Sparse headers (pulled in through ACCELERATE_NEW_LAPACK) trip a large, SDK-version-dependent set of -Wpedantic/GNU-extension warnings: _Nullable/_Nonnull nullability qualifiers, zero-arg variadic macros, extra semicolons, and more. On the Xcode SDK this floods the build with tens of thousands of warnings from headers we cannot fix. Mark the Accelerate include as a system header with `#pragma clang system_header` so all of its warnings are suppressed regardless of which flag or SDK version produces them, while our own code keeps full -Wpedantic strictness. cblas_wrapper.h contains nothing but the include, so the marker is effectively scoped to Accelerate. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove warnings that are caused by library we use