feat: streaming uploadData for node and browser envs - #9
Closed
bosi95 wants to merge 2 commits into
Closed
Conversation
Cafe137
reviewed
Jul 20, 2026
| { ...config, data: undefined }, | ||
| options, | ||
| ) | ||
| requestConfig.data = rawData |
There was a problem hiding this comment.
Why not just data: rawData instead of data: undefined? This part is not fully clear why we explicitly assign undefined first
Author
There was a problem hiding this comment.
I think that also works. deepmerge3 sets data to undefined so it doesn't really matter. the point is to reassign requestConfig.data so that it persists.
Author
|
Obsolete: PR ethersphere#1239 replaces this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.