Skip to content

Add an exact debugger target registry - #170

Draft
bjdodson-openai wants to merge 1 commit into
bjd/debugger-console-clearfrom
bjd/debugger-target-registry
Draft

Add an exact debugger target registry#170
bjdodson-openai wants to merge 1 commit into
bjd/debugger-console-clearfrom
bjd/debugger-target-registry

Conversation

@bjdodson-openai

Copy link
Copy Markdown
Collaborator

Description

Adds backend-only exact opaque target discovery and resolution for inspected pages, native runtimes, and Chromium endpoints.

  • Makes target identity globally one-to-one across daemon and canonical transport tuples.
  • Rejects invalid, duplicate, ambiguous, fragmented, and oversized endpoint claims.
  • Advertises only capabilities supported by each target's actual transport.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation improvement
  • Performance optimization
  • Test improvement
  • Other (new debugger capability)

Testing

  • Tests pass locally (bazel test //...)
  • Added/updated tests for changes (if applicable)
  • Tested on multiple platforms (iOS/Android/Web/macOS as applicable)
  • Manual testing performed (describe below)

Testing Details

  • Incremental branch: Focused registry/server 96/96, full CLI 372/372, production build, package, lint, format, diff, and repository query passed.
  • Assembled debugger stack: npm test passed 436/436; the CLI production build passed.
  • Focused //src/valdi_modules/src/valdi/web_renderer:test passed.
  • bazel query //... passed.
  • The broad Valdi suite reproduced the established 12 unrelated failures; all new debugger specs passed.

Checklist

  • Code follows project style guidelines
  • Documentation updated (if needed)
  • No breaking changes (or documented in description)
  • Commit messages follow conventional format
  • No secrets, API keys, or internal URLs included

Related Issues

Relates to #154

Additional Context

Stack 17/22. Stacked on #169 (bjd/debugger-console-clear). Review this PR as the single incremental commit c0f45f45 against that base; do not merge it before its parent.

@github-actions

Copy link
Copy Markdown

📊 PR Size: size/XL

Total changes: 2167 lines (7 files)

Top files changed:

  • npm_modules/cli/src/debugger/server.spec.ts: +558 -3
  • npm_modules/cli/src/debugger/targetRegistry.ts: +524 -0
  • npm_modules/cli/src/debugger/targetRegistry.spec.ts: +513 -0
  • npm_modules/cli/src/debugger/server.ts: +401 -13
  • npm_modules/cli/src/utils/daemonClient.ts: +50 -17
  • npm_modules/cli/src/utils/daemonClient.spec.ts: +60 -1
  • npm_modules/cli/debugger/README.md: +25 -2

Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant