fix: make research placeholder use same math logic as stats#4320
Open
DereC4 wants to merge 1 commit intoSlimefun:experimentalfrom
Open
fix: make research placeholder use same math logic as stats#4320DereC4 wants to merge 1 commit intoSlimefun:experimentalfrom
DereC4 wants to merge 1 commit intoSlimefun:experimentalfrom
Conversation
Contributor
|
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The data displayed by the placeholder %slimefun_researches_percentage_researches_unlocked% displays data from all slimefun items (including the disabled ones) while the /sf stats displays data from all slimefun items (except the disabled ones).
Proposed changes
I'm not sure about style guide or how you wanted parity to happen, so I went with the more logical approach. Adjusted the placeholder calculation to remove disabled researches from the calculation, which matches what the /stats command does.
Made the countNonEmptyResearches public to access it from placeholder with our provided profile instance.
Related Issues (if applicable)
#4277
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values