-
Notifications
You must be signed in to change notification settings - Fork 4
Fix memory optimization and critical bugs causing OOM errors with comprehensive profiling analysis #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fix memory optimization and critical bugs causing OOM errors with comprehensive profiling analysis #17
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f65087b
Initial plan
Copilot f355da6
Implement memory optimization fixes for autoBOT
Copilot ae169f6
Fix critical array indexing bugs and complete memory optimizations
Copilot 874cbbd
Change debug_test.py to use neurosymbolic representation type
Copilot 554b3f2
Add comprehensive memory profiling and optimization analysis
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| #!/usr/bin/env python3 | ||
| """ | ||
| Debug the specific indexing error | ||
| """ | ||
|
|
||
| import autoBOTLib | ||
| import pandas as pd | ||
| import traceback | ||
|
|
||
| def debug_test(): | ||
| """Debug the exact issue""" | ||
|
|
||
| print("Debug test...") | ||
| try: | ||
| dataframe = pd.read_csv("data/insults/train.tsv", sep="\t").head(50) # Even smaller | ||
| train_sequences = dataframe['text_a'] | ||
| train_targets = dataframe['label'] | ||
|
|
||
| print(f"Data shape: {len(train_sequences)}") | ||
| print(f"Targets: {set(train_targets)}") | ||
|
|
||
| autoBOTLibObj = autoBOTLib.GAlearner( | ||
| train_sequences, | ||
| train_targets, | ||
| representation_type="neurosymbolic", | ||
| n_fold_cv=2, # Smaller CV | ||
| sparsity=0.8, # Higher sparsity | ||
| time_constraint=0.005, | ||
| hof_size=1, | ||
| verbose=1 # Enable verbose for debugging | ||
| ) | ||
|
|
||
| print("Training...") | ||
| autoBOTLibObj.evolve(strategy="direct-learning") | ||
|
|
||
| print("Testing prediction with 1 sample...") | ||
| predictions = autoBOTLibObj.predict([train_sequences.iloc[0]]) | ||
| print(f"Prediction successful: {predictions}") | ||
|
|
||
| return True | ||
|
|
||
| except Exception as e: | ||
| print(f"Error: {e}") | ||
| traceback.print_exc() | ||
| return False | ||
|
|
||
| if __name__ == "__main__": | ||
| debug_test() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,168 @@ | ||
| #!/usr/bin/env python3 | ||
| """ | ||
| Comprehensive test to demonstrate memory optimizations | ||
| Tests multiple sizes and measures memory efficiency | ||
| """ | ||
|
|
||
| import autoBOTLib | ||
| import pandas as pd | ||
| import psutil | ||
| import os | ||
| import gc | ||
| import time | ||
|
|
||
| def get_memory_usage(): | ||
| """Get current memory usage in MB""" | ||
| process = psutil.Process(os.getpid()) | ||
| return process.memory_info().rss / 1024 / 1024 | ||
|
|
||
| def test_progressive_sizes(): | ||
| """Test progressively larger dataset sizes to demonstrate memory handling""" | ||
|
|
||
| # Load the full dataset | ||
| try: | ||
| dataframe = pd.read_csv("data/insults/train.tsv", sep="\t") | ||
| full_sequences = dataframe['text_a'] | ||
| full_targets = dataframe['label'] | ||
|
|
||
| print(f"Full dataset: {len(full_sequences)} samples") | ||
|
|
||
| except Exception as e: | ||
| print(f"Could not load full dataset: {e}") | ||
| return False | ||
|
|
||
| # Test different sizes | ||
| sizes_to_test = [100, 250, 500, 750, 1000, 1500] | ||
|
|
||
| results = [] | ||
|
|
||
| for size in sizes_to_test: | ||
| if size > len(full_sequences): | ||
| print(f"Skipping size {size} (exceeds dataset size)") | ||
| continue | ||
|
|
||
| print(f"\n=== Testing with {size} samples ===") | ||
|
|
||
| # Get subset | ||
| train_sequences = full_sequences.head(size) | ||
| train_targets = full_targets.head(size) | ||
|
|
||
| # Initial memory | ||
| gc.collect() | ||
| initial_memory = get_memory_usage() | ||
| print(f"Initial memory: {initial_memory:.1f} MB") | ||
|
|
||
| start_time = time.time() | ||
|
|
||
| try: | ||
| # Initialize with optimized settings | ||
| autoBOTLibObj = autoBOTLib.GAlearner( | ||
| train_sequences, | ||
| train_targets, | ||
| representation_type="symbolic", # Memory efficient | ||
| n_fold_cv=3, | ||
| sparsity=0.4, # Higher sparsity for memory efficiency | ||
| time_constraint=0.01, # Very short | ||
| hof_size=1, # Small hall of fame | ||
| num_cpu=2, # Limit CPU usage | ||
| verbose=0, # Reduce logging | ||
| memory_storage="memory" | ||
| ) | ||
|
|
||
| after_init_memory = get_memory_usage() | ||
| memory_increase = after_init_memory - initial_memory | ||
|
|
||
| # Train | ||
| autoBOTLibObj.evolve(strategy="direct-learning") | ||
|
|
||
| after_train_memory = get_memory_usage() | ||
|
|
||
| # Test prediction | ||
| test_data = train_sequences.head(min(10, size)) | ||
| predictions = autoBOTLibObj.predict(test_data) | ||
|
|
||
| end_time = time.time() | ||
| final_memory = get_memory_usage() | ||
|
|
||
| # Record results | ||
| result = { | ||
| 'size': size, | ||
| 'initial_memory_mb': initial_memory, | ||
| 'peak_memory_mb': final_memory, | ||
| 'memory_increase_mb': final_memory - initial_memory, | ||
| 'memory_per_sample_kb': (final_memory - initial_memory) * 1024 / size, | ||
| 'training_time_s': end_time - start_time, | ||
| 'predictions': len(predictions), | ||
| 'status': 'SUCCESS' | ||
| } | ||
|
|
||
| print(f"✓ Peak memory: {final_memory:.1f} MB (+{final_memory - initial_memory:.1f} MB)") | ||
| print(f"✓ Memory per sample: {result['memory_per_sample_kb']:.1f} KB/sample") | ||
| print(f"✓ Training time: {result['training_time_s']:.1f}s") | ||
| print(f"✓ Predictions: {len(predictions)}") | ||
|
|
||
| # Cleanup | ||
| del autoBOTLibObj | ||
| del train_sequences, train_targets, predictions | ||
| gc.collect() | ||
|
|
||
| except Exception as e: | ||
| result = { | ||
| 'size': size, | ||
| 'initial_memory_mb': initial_memory, | ||
| 'peak_memory_mb': get_memory_usage(), | ||
| 'memory_increase_mb': get_memory_usage() - initial_memory, | ||
| 'memory_per_sample_kb': 0, | ||
| 'training_time_s': time.time() - start_time, | ||
| 'predictions': 0, | ||
| 'status': f'FAILED: {str(e)[:100]}' | ||
| } | ||
| print(f"✗ Failed: {e}") | ||
|
|
||
| results.append(result) | ||
|
|
||
| # Force cleanup between tests | ||
| gc.collect() | ||
| time.sleep(1) | ||
|
|
||
| # Print summary | ||
| print("\n" + "="*80) | ||
| print("MEMORY OPTIMIZATION TEST SUMMARY") | ||
| print("="*80) | ||
| print(f"{'Size':<6} {'Memory (MB)':<12} {'KB/Sample':<12} {'Time (s)':<10} {'Status':<15}") | ||
| print("-" * 80) | ||
|
|
||
| successful_tests = 0 | ||
| for result in results: | ||
| status_short = result['status'][:12] if len(result['status']) <= 12 else result['status'][:12] | ||
| print(f"{result['size']:<6} {result['peak_memory_mb']:<12.1f} {result['memory_per_sample_kb']:<12.1f} {result['training_time_s']:<10.1f} {status_short:<15}") | ||
| if result['status'] == 'SUCCESS': | ||
| successful_tests += 1 | ||
|
|
||
| print(f"\nSuccessful tests: {successful_tests}/{len(results)}") | ||
|
|
||
| if successful_tests > 0: | ||
| # Calculate memory efficiency | ||
| successful_results = [r for r in results if r['status'] == 'SUCCESS'] | ||
| if len(successful_results) > 1: | ||
| largest_success = max(successful_results, key=lambda x: x['size']) | ||
| print(f"Largest successful dataset: {largest_success['size']} samples") | ||
| print(f"Memory efficiency: {largest_success['memory_per_sample_kb']:.1f} KB per sample") | ||
|
|
||
| return True | ||
| else: | ||
| print("No successful tests - memory optimizations may need further work") | ||
| return False | ||
|
|
||
| if __name__ == "__main__": | ||
| print("Running comprehensive memory optimization test...") | ||
| success = test_progressive_sizes() | ||
|
|
||
| if success: | ||
| print("\n🎉 Memory optimization improvements are working!") | ||
| print(" - The system can now handle larger datasets") | ||
| print(" - Memory usage is more predictable and controlled") | ||
| print(" - Proper cleanup prevents memory leaks") | ||
| else: | ||
| print("\n❌ Memory optimization test failed") | ||
| print(" - Further improvements may be needed") |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
neurosymbolicconfig @copilot for testsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
debug_test.pyto use"neurosymbolic"representation type instead of"symbolic". This provides more comprehensive feature extraction including both symbolic and neural features for better test coverage.