[sitecore-jss][sitecore-jss-react] Enhance withDatasourceCheck() to support dataSourceResolveFailed - #2219
Open
sc-naveenhedallaarachchi wants to merge 3 commits into
Open
Conversation
…ithDatasourceCheck
art-alexeyenko
approved these changes
Aug 25, 2026
art-alexeyenko
left a comment
Contributor
There was a problem hiding this comment.
Looks good - but please double check whether SXP 10.5 will provide the isContentResolved field in layout data. If not - there's no usecase for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation
dataSourceResolveFailedtoComponentRendering.dataSourceResolveFailed: truethe same as a missing datasource inwithDatasourceCheck()(hide in normal mode, editing error in editing mode).falseor omitted so older Layout Service versions keep working.withDatasourceCheck()JSDoc example.Testing Details
dataSourceResolveFailed: falsestill renders the wrapped component.dataSourceResolveFailed: truehides the component in normal mode and shows the editing error in editing mode.Types of changes