Skip to content

[Performance] Optimize rejectGeneratedStaticAssets filtering #8373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gonzaloriestra wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Performance] Optimize rejectGeneratedStaticAssets filtering #8373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/theme/src/cli/utilities/asset-checksum.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,12 @@ function md5(content: string | Buffer) {
* as these are not needed for theme comparison.
*/
export function rejectGeneratedStaticAssets(themeChecksums: Checksum[]) {
const liquidAssetKeys = new Set(
themeChecksums.filter(({key}) => key.startsWith('assets/') && key.endsWith('.liquid')).map(({key}) => key),
)
const liquidAssetKeys = new Set<string>()
for (const {key} of themeChecksums) {
if (key.startsWith('assets/') && key.endsWith('.liquid')) {
liquidAssetKeys.add(key)
}
}

return themeChecksums.filter(({key}) => {
const isStaticAsset = key.startsWith('assets/')
Expand Down
Loading