-
Notifications
You must be signed in to change notification settings - Fork 29
Fix prompts for audiollm for misrepresenting_tool_result and information_loss #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,6 +37,32 @@ def test_get_prompt_variables_s2s(self): | |
| variables = self.metric.get_prompt_variables(ctx, "transcript") | ||
| assert "speech-to-speech" in variables["user_turns_disclaimer"] | ||
| assert "raw audio" in variables["disambiguation_context"] | ||
| # S2S traces show STT-of-audio for assistant turns, so the artifact carve-out applies. | ||
| assert variables["misrepresentation_pipeline_note"] != "" | ||
| assert "STT transcriptions of the agent" in variables["assistant_turns_disclaimer"] | ||
|
|
||
| def test_get_prompt_variables_audio_llm(self): | ||
| # AUDIO_LLM hears user audio directly (so disambiguation is audio-native), but its | ||
| # assistant turns in the trace are the LLM's literal *text* output, not STT-of-audio. | ||
| # Character-level slips there are real, so the misrepresentation/info-loss carve-outs | ||
| # must NOT apply and the assistant-turns disclaimer must be the intended-text one. | ||
| ctx = make_metric_context(pipeline_type="audio_llm") | ||
| variables = self.metric.get_prompt_variables(ctx, "transcript") | ||
| # Audio-native perception → S2S-style user/disambiguation framing. | ||
| assert "raw audio" in variables["disambiguation_context"] | ||
| assert "speech-to-speech" in variables["user_turns_disclaimer"] | ||
| # Trace provenance is text, not audio → no free pass on character-level slips. | ||
| assert variables["misrepresentation_pipeline_note"] == "" | ||
| assert "STT transcriptions of the agent" not in variables["assistant_turns_disclaimer"] | ||
| assert "intended text" in variables["assistant_turns_disclaimer"] | ||
|
|
||
| def test_disambiguation_context_drops_comparative_bar(self): | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test is a bit weird to me - I don't think we need to test its not longer there.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah good point! i'll remove |
||
| # The bare "bar is higher than a text-based system" clause was removed: it added | ||
| # severity pressure without an operational criterion. The concrete expectation stays. | ||
| ctx = make_metric_context(pipeline_type="s2s") | ||
| variables = self.metric.get_prompt_variables(ctx, "transcript") | ||
| assert "higher than for a text-based system" not in variables["disambiguation_context"] | ||
| assert "alphanumeric codes" in variables["disambiguation_context"] | ||
|
|
||
| def test_build_metric_score(self): | ||
| ctx = make_metric_context(conversation_trace=[{"role": "user"}, {"role": "assistant"}]) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That won't match ElevenLabs agents that is marked as s2s, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we switch elevenlabs agents pipeline type to cascade earlier in the process so it is cascade when it reaches here