Update ILRepack package references and enhance nullability handling i…#303
Merged
SergeyTeplyakov merged 1 commit intomasterfrom Jun 29, 2025
Merged
Update ILRepack package references and enhance nullability handling i…#303SergeyTeplyakov merged 1 commit intomasterfrom
SergeyTeplyakov merged 1 commit intomasterfrom
Conversation
…n DoNotReturnNullForTaskLikeAnalyzer
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR updates the ILRepack package references to use the “Task” variant at a new version and enhances nullability handling in the Task-like analyzer.
- Allow the
findParentLocalOrLambdaSymbolhelper to accept a nullableIOperation - Swap
ILRepack.Lib.MSBuildforILRepack.Lib.MSBuild.Taskand adjust the package version - Align the Directory.Build.props reference to the new ILRepack.Task package
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ErrorProne.NET.CoreAnalyzers/AsyncAnalyzers/DoNotReturnNullForTaskLikeAnalyzer.cs | Make findParentLocalOrLambdaSymbol accept nullable IOperation |
| src/Directory.Packages.props | Replace ILRepack.Lib.MSBuild with ILRepack.Lib.MSBuild.Task version 2.0.43 |
| src/Directory.Build.props | Update PackageReference to ILRepack.Lib.MSBuild.Task |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n DoNotReturnNullForTaskLikeAnalyzer