Bonanoo

.gitignore

@@ -17,6 +17,8 @@ devapp/permissions.json
 devapp/resource_packs
 devapp/behavior_packs
 
+bds
+
 # Swap the comments on the following lines if you don't wish to use zero-installs
 # Documentation here: https://yarnpkg.com/features/zero-installs
 # !.yarn/cache

bundle/index.ts

@@ -34,5 +34,7 @@ if (isMainThread) {
   serenity.registerProvider(LevelDBProvider, { path: "./worlds" });
 
   // Start the server
-  serenity.start();
+  serenity.start().then(() => { }).catch((error) => {
+    serenity.logger.error("Failed to start SerenityJS server:", error);
+  });
 }

devapp/src/index.ts

@@ -17,4 +17,6 @@ new Pipeline(serenity, { path: "./plugins" });
 serenity.registerProvider(LevelDBProvider, { path: "./worlds" });
 
 // Start the server
-serenity.start();
+serenity.start().catch((reason) => {
+  serenity.logger.error("Failed to start SerenityJS server:", reason);
+});

packages/core/src/block/container.ts

@@ -1,15 +1,16 @@
 import {
+  BlockPosition,
+  type IPosition,
   ContainerId,
   ContainerOpenPacket,
   ContainerType
 } from "@serenityjs/protocol";
 
 import { Container } from "../container";
-import { ItemStack } from "../item";
-import { Player } from "../entity";
-import { PlayerOpenedContainerSignal } from "../events";
-
-import { Block } from "./block";
+import { ItemStack } from "../item/stack";
+import { Player } from "../entity/player";
+import { PlayerOpenedContainerSignal } from "../events/player-opened-container";
+import type { Block } from "./block";
 
 class BlockContainer extends Container {
   /**
@@ -37,6 +38,19 @@
     // Call the original update method
     super.update();
 
+    // Call the onContainerUpdate method for the block traits
+    this.notifyTraits();
+  }
+
+  public updateSlot(slot: number): void {
+    // Call the original updateSlot method
+    super.updateSlot(slot);
+
+    // Call the onContainerUpdate method for the block traits
+    this.notifyTraits();
+  }
+
+  private notifyTraits(): void {
     // Call the onContainerUpdate method for the block traits
     for (const trait of this.block.getAllTraits()) {
       try {
@@ -56,7 +70,7 @@
     }
   }
 
-  public show(player: Player): number {
+  public show(player: Player, position: IPosition = this.block.position): number {
     // Create a new PlayerOpenedContainerSignal
     const signal = new PlayerOpenedContainerSignal(player, this);
 
@@ -72,16 +86,31 @@
     // Assign the properties
     packet.identifier = identifier;
     packet.type = this.type;
-    packet.position = this.block.position;
-    packet.uniqueId =
-      this.type === ContainerType.Container ? -1n : player.uniqueId;
+    packet.position = position instanceof BlockPosition
+      ? position
+      : new BlockPosition(position.x, position.y, position.z);
+    // Vanilla/BDS uses -1 for block container windows, including hoppers.
+    packet.uniqueId = -1n;
 
     // Send the packet to the player
     player.send(packet);
 
     // Update the container
     this.update();
 
+    // Some block container UIs (such as furnaces) ignore the initial full
+    // content snapshot until the window exists client-side. Re-send the slots
+    // on the next tick once the container is definitely open. dunno why its done like this here but i aint rewriting all that
+    if (this.type !== ContainerType.Container) {
+      this.block.dimension.schedule(1).on(() => {
+        if (!this.getAllOccupants().some(([occupant]) => occupant === player)) return;
+
+        for (let slot = 0; slot < this.getSize(); slot++) {
+          this.updateSlot(slot);
+        }
+      });
+    }
+
     // Return the container identifier
     return identifier;
   }