feat: build gamification system core by AdamStajer07 · Pull Request #1800 · Selleo/mentingo

AdamStajer07 · 2026-07-22T11:11:34Z

Issue(s)

Overview

Implementation of gamification core.
System of rewarding users for activities in platform
Gamification worker uses activityLogs to listen to new events, and after that checks new user's achievements. Every achievement could have many levels. Every level of achievement could have different xpReward. User's xp has 2 categories: spendable and lifetime. Lifetime couldn't be dicreased.
Type of achievements is defined based on resourceType and actionType from activityLogs (e.g. "user" and "login")

If user receives new achievement, websocket emits message to the front-end and user receives notification.
Every user's achievements are in his profile page.

Business Value

Automatic, consistent recognition of learning activity increases learner motivation and engagement, giving users clear, immediate feedback on their progress instead of relying on passive course completion alone.

Screenshots / Video

…ification handler, achievement notifications websocket emit, list of achievements in profile page

…nction in service

Pieselak

Overall it looks decent, but needs some minor corrections

Pieselak · 2026-07-22T11:51:27Z

+      .delete(achievements)
+      .where(eq(achievements.id, achievementId))
+      .returning({ id: achievements.id });
+    if (!deletedAchievement) throw new BadRequestException("common.error");


Same as above

Pieselak · 2026-07-22T11:52:38Z

+      .returning();
+
+    if (!updatedAchievement) {
+      throw new BadRequestException("error");


Why throw BadRequestException here? I think NotFoundException will be better here. Also use a valid translation key

Pieselak · 2026-07-22T11:57:27Z

+      .where(eq(achievements.id, achievementId));
+
+    if (!achievement) {
+      throw new BadRequestException("error");


Why throw BadRequestException here? I think NotFoundException will be better here. Also use a valid translation key

Pieselak · 2026-07-22T12:00:43Z

+        id: achievements.id,
+        key: achievements.key,
+      });
+    if (!createdAchievement) throw new BadRequestException("error");


You can delete this check as it's useless (also exception type is incorrect)

Pieselak · 2026-07-22T12:01:25Z

+      .returning({
+        id: achievementLevels.id,
+      });
+    if (!updatedLevel) throw new BadRequestException("error");


Why throw BadRequestException here? I think NotFoundException will be better here. Also use a valid translation key

Pieselak · 2026-07-22T12:04:48Z

+    type: "post" | "update",
+    levelNumber?: number,
+  ) {
+    if (!threshold) throw new BadRequestException("common.error");


Use a valid translation key

Pieselak · 2026-07-22T12:12:10Z

+      .where(eq(userProgress.userId, currentUser.userId));
+
+    if (!progress) {
+      throw new BadRequestException("common.error");


Why throw BadRequestException here? I think NotFoundException will be better here. Also use a valid translation key

Pieselak · 2026-07-22T12:21:17Z

+export function resetSocket(): void {
+  if (!socket) return;
+
+  socket.disconnect();
+  socket.connect();
+}


Maybe use a different name for this function, maybe reconnectSocket. The current name might be confusing

Pieselak · 2026-07-22T12:28:15Z

+
+              <span className="text-sm text-neutral-600">
+                {level.earnedAt
+                  ? new Date(level.earnedAt).toLocaleString("pl-PL").slice(0, -3)


Maybe use Intl.DateTimeFormat with user lang code instead?

Pieselak · 2026-07-22T12:28:30Z

+
+      {achievement.currentLevel.earnedAt && (
+        <span className="text-xs text-neutral-500">
+          {new Date(achievement.currentLevel.earnedAt).toLocaleDateString()}


Same as above

mountain-bit

This looks solid.

mountain-bit · 2026-07-22T12:48:56Z

+  const hasHistory = achievement.history.length > 1;
+
+  return (
+    <button


Maybe use component instead?

pkrzysiekk

Looks great to me

…d, change achievementsCarousel into more ui-component

mountain-bit

Pretty good overall! I only have one suggestion: avoid hardcoding locale-specific values

mountain-bit · 2026-07-23T12:58:50Z

  "justify-between flex w-full max-w-[720px] flex-col gap-y-6 rounded-b-lg rounded-t-2xl bg-white p-6 drop-shadow";

+function formatDate(date: string, options: Intl.DateTimeFormatOptions): string {
+  return new Intl.DateTimeFormat("pl-PL", options).format(new Date(date));


pl-PL is hardcoded here. Could we use the application's current locale to support all languages?

AdamStajer07 · 2026-07-23T13:18:31Z

Changing default trophy Icon for own SVG Achievement icon

…ding. Change achievements avatar for new. Add missing gamification errors translation

its-gabo

Good job, it needs some things to be worked on

its-gabo · 2026-07-27T08:56:22Z

+export const createTranslationSchema = Type.Object({
+  key: Type.String(),
+});


I'm not sure about this the name of the columns. It's kinda deceiving. Let's rename it to something like title.

its-gabo · 2026-07-27T08:56:46Z

+
+@Controller("achievements")
+export class AchievementsController {
+  constructor(private readonly achievementsService: AchievementsService) {}


Suggested change

constructor(private readonly achievementsService: AchievementsService) {}

constructor(private readonly achievementsService: AchievementsService) {}

its-gabo · 2026-07-27T09:01:22Z

+  UpdateAchievementLevel,
+} from "./schema/updateAchievementLevel.schema";
+
+@Controller("achievements")


In the entire file we're missing permission checks.

We'll need to use @RequirePermission decorator with proper permissions. Now everyone can do anything with the achievement through the API.

its-gabo · 2026-07-27T09:12:35Z

+  @Get()
+  async getAchievementsList(
+    @Query("is-enabled") isEnabled: boolean,
+    @Query("visibility") visibility: GamificationVisibility,


I would derive it from user permissions rather than through query param - someone can manually change the query

its-gabo · 2026-07-27T09:15:49Z

+  async validateThreshold(
+    achievementId: UUIDType,
+    threshold: number | undefined,
+    type: "post" | "update",


Let's create a enum for it ({} as const) and derive type from it

its-gabo · 2026-07-27T10:10:40Z

+        if (!event.resourceType) throw new Error("common.error.somethingWentWrong");
+        await this.tenantRunner.runWithTenant(event.tenantId, async () => {
+          this.logger.log(`Processing gamification event: ${event.actionType}`);
+          await new Promise((resolve) => setTimeout(resolve, 500));


Why is the additional timeout here?

its-gabo · 2026-07-27T10:11:18Z

+
+    tenantId,
+
+    key: jsonb("key").$type<LocalizedText>().default({}).notNull(),


I'd change it to title

its-gabo · 2026-07-27T10:13:06Z


 const TOAST_LIMIT = 1;
-const TOAST_REMOVE_DELAY = 1000000;
+const TOAST_REMOVE_DELAY = 10000;


Why was this changed?

its-gabo · 2026-07-27T10:14:03Z

+function formatDate(date: string, options: Intl.DateTimeFormatOptions, language: string): string {
+  return new Intl.DateTimeFormat(language, options).format(new Date(date));
+}
+
+function groupAchievements(achievements: UserAchievement[]): GroupedAchievement[] {
+  const achievementsMap = new Map<string, UserAchievement[]>();
+
+  achievements.forEach((achievement) => {
+    const existingAchievements = achievementsMap.get(achievement.achievementId) ?? [];
+    existingAchievements.push(achievement);
+    achievementsMap.set(achievement.achievementId, existingAchievements);
+  });


Let's extract the utils to separate file

its-gabo · 2026-07-27T10:15:44Z

    canViewExtendedProfile,
  );

+  const { data: achievements } = useUserAchievements(language);


There will be issue when a user will go to students profile - he will see his own achievements rather than the student's

mountain-bit

Looks good to me. The only thing left is to resolve the conflicts.

pkrzysiekk

Changes look good

AdamStajer07 added 4 commits July 9, 2026 12:28

build drizzle-kit new tables schemes

2423e54

create gamification module

e174acf

feat: build gamification core. Create gamification tables schema, gam…

e1ee6c1

…ification handler, achievement notifications websocket emit, list of achievements in profile page

fix: repair activity-logs.service.spec.ts Adjust test standards to fu…

f83eca0

…nction in service

AdamStajer07 self-assigned this Jul 22, 2026

AdamStajer07 added 5 commits July 22, 2026 13:27

fix: repair db migrations

8727116

merge: staging into as_feat_1722_build_gamification_system_core

2391fc1

fix: migration after rebase

5e16304

fix: repair UserAchievement type error

bcad913

fix: repair type of errors and errors messages

fd71c42

AdamStajer07 requested review from its-gabo, mountain-bit and pkrzysiekk July 22, 2026 12:07

Pieselak reviewed Jul 22, 2026

View reviewed changes

AdamStajer07 removed the request for review from its-gabo July 22, 2026 12:40

mountain-bit requested changes Jul 22, 2026

View reviewed changes

pkrzysiekk approved these changes Jul 23, 2026

View reviewed changes

fix: set error's messages, change way of formatting dates in front-en…

db03094

…d, change achievementsCarousel into more ui-component

AdamStajer07 requested review from Pieselak and mountain-bit July 23, 2026 12:48

mountain-bit requested changes Jul 23, 2026

View reviewed changes

fix: set user language in formatDate

b8c1008

AdamStajer07 requested a review from its-gabo July 23, 2026 13:29

fix: change achievements carousel in profile from ascending to descen…

3111c46

…ding. Change achievements avatar for new. Add missing gamification errors translation

its-gabo requested changes Jul 27, 2026

View reviewed changes

fix: apply fixes from review and write tests

090615d

AdamStajer07 requested review from its-gabo, mountain-bit and pkrzysiekk July 30, 2026 10:04

mountain-bit approved these changes Jul 30, 2026

View reviewed changes

AdamStajer07 added 5 commits July 30, 2026 12:27

fix: prepare for merge

423acda

merge: resolve conflicts

6f88003

fix: add gamification schema

96d5aa8

fix: repair tests :)

539887c

fix: repair front-end tests :)

1e36e25

pkrzysiekk approved these changes Jul 31, 2026

View reviewed changes

	constructor(private readonly achievementsService: AchievementsService) {}
	constructor(private readonly achievementsService: AchievementsService) {}


		tenantId,

		key: jsonb("key").$type<LocalizedText>().default({}).notNull(),

Uh oh!

Conversation

AdamStajer07 commented Jul 22, 2026

Issue(s)

Overview

Business Value

Screenshots / Video

Uh oh!

Pieselak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountain-bit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pkrzysiekk left a comment

Choose a reason for hiding this comment

Uh oh!

mountain-bit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdamStajer07 commented Jul 23, 2026

Uh oh!

its-gabo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountain-bit left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pkrzysiekk left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

mountain-bit left a comment •

edited

Loading