Skip to content

update website homepage for the conference information#2637

Merged
diemol merged 2 commits into
SeleniumHQ:trunkfrom
rpallavisharma:updateHomePage-pal
May 15, 2026
Merged

update website homepage for the conference information#2637
diemol merged 2 commits into
SeleniumHQ:trunkfrom
rpallavisharma:updateHomePage-pal

Conversation

@rpallavisharma
Copy link
Copy Markdown
Member

@rpallavisharma rpallavisharma commented May 14, 2026

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

update website homepage for the conference information

Motivation and Context

conference is done, update website homepage for the conference information

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 14, 2026

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit 3aec158
🔍 Latest deploy log https://app.netlify.com/projects/selenium-dev/deploys/6a072bfb594f76000872a30b
😎 Deploy Preview https://deploy-preview-2637--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@qodo-code-review
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Update homepage announcement banner post-conference

📝 Documentation

Grey Divider

Walkthroughs

Description
• Updates announcement banner with post-conference thank you message
• Changes registration link to general conference website link
• Reflects completion of Selenium and Appium 2026 Conference event
Diagram
flowchart LR
  old["Registration announcement<br/>with register link"]
  new["Thank you message<br/>with conference website link"]
  old -- "Conference concluded" --> new
Loading

Grey Divider

File Changes

1. website_and_docs/layouts/partials/announcement-banner.html 📝 Documentation +3/-3

Update announcement banner to post-conference message

• Replaced registration call-to-action with thank you message
• Updated announcement text from "Registrations Open for SeleniumConf 2026" to "Thank you for
 joining the Selenium and Appium 2026 Conference"
• Changed link destination from registration page to main conference website
• Updated link text from "Register now!" to "Visit Conference Website for more information!"

website_and_docs/layouts/partials/announcement-banner.html


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented May 14, 2026

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0)

Grey Divider


Action required

1. Missing noopener on _blank 🐞 Bug ⛨ Security
Description
The announcement banner opens an external link with target='_blank' but omits rel="noopener
noreferrer", which allows reverse-tabnabbing via window.opener if the destination is ever
compromised. This banner is enabled via site params and rendered below the navbar, so the risk
affects all site visitors while the banner is on.
Code

website_and_docs/layouts/partials/announcement-banner.html[R15-16]

+                 <a href="https://seleniumconf.com/"
+                    target='_blank' aria-pressed="true"> Visit Conference Website for more information!</a>
Evidence
The banner’s conference link uses target='_blank' without any rel attribute, while other site
templates consistently include rel="noopener"/rel="noopener noreferrer" for _blank links. The
banner is also wired to be shown when params.announcement_banner is true and is included by the
navbar partial, making it site-wide.

website_and_docs/layouts/partials/announcement-banner.html[14-16]
website_and_docs/layouts/partials/footer.html[28-42]
website_and_docs/content/ecosystem/_index.html[69-78]
website_and_docs/hugo.toml[160-163]
website_and_docs/layouts/partials/navbar.html[54-56]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The announcement banner link uses `target='_blank'` without `rel="noopener noreferrer"`, enabling reverse-tabnabbing (opened page can manipulate the opener tab).

### Issue Context
Other parts of this site already protect `_blank` links with `rel="noopener"` / `rel="noopener noreferrer"`, but the announcement banner does not.

### Fix Focus Areas
- website_and_docs/layouts/partials/announcement-banner.html[14-16]
- website_and_docs/layouts/partials/footer.html[28-42]
- website_and_docs/content/ecosystem/_index.html[69-78]
- website_and_docs/hugo.toml[160-163]
- website_and_docs/layouts/partials/navbar.html[54-56]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Misused aria-pressed on link 🐞 Bug ≡ Correctness
Description
The announcement banner adds aria-pressed="true" to a normal <a href=...> link, which is an ARIA
state intended for toggle buttons and can cause assistive technologies to announce an incorrect
pressed/toggle state. This makes the banner less accessible while it is enabled site-wide.
Code

website_and_docs/layouts/partials/announcement-banner.html[R15-16]

+                 <a href="https://seleniumconf.com/"
+                    target='_blank' aria-pressed="true"> Visit Conference Website for more information!</a>
Evidence
The banner markup shows an <a> element with an href and target but also includes
aria-pressed="true", even though it is not a button/toggle control. The navbar template includes
this partial when announcement_banner is enabled, so this markup is surfaced broadly.

website_and_docs/layouts/partials/announcement-banner.html[14-16]
website_and_docs/layouts/partials/navbar.html[54-56]
website_and_docs/hugo.toml[160-163]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`aria-pressed="true"` is applied to a plain anchor link in the announcement banner, which is not a toggle control.

### Issue Context
This banner content is rendered under the navbar when `params.announcement_banner` is enabled.

### Fix Focus Areas
- website_and_docs/layouts/partials/announcement-banner.html[14-16]
- website_and_docs/layouts/partials/navbar.html[54-56]
- website_and_docs/hugo.toml[160-163]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

Comment thread website_and_docs/layouts/partials/announcement-banner.html
@diemol diemol merged commit 4aed31f into SeleniumHQ:trunk May 15, 2026
6 checks passed
selenium-ci added a commit that referenced this pull request May 15, 2026
update website homepage conf information

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>

[deploy site] 4aed31f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants